Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Lee Jones
@@ -964,11 +966,13 @@ static int __devinit ab8500_btemp_probe(struct platform_device *pdev) { int irq, i, ret = 0; u8 val; - struct abx500_bm_plat_data *plat_data = pdev->dev.platform_data; I already told you about this. your previous comment was: "No, it's meant to work

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
> Date: Tue, 10 Jul 2012 14:12:01 + > From: Arnd Bergmann > To: linux-arm-ker...@lists.infradead.org > Cc: linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, > "Rajanikanth H.V" , patc...@linaro.org > Subject: Re: [PATCH] mfd: Implement d

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
> Date: Tue, 10 Jul 2012 18:20:13 +0200 > From: Lee Jones > To: "Rajanikanth H.V" > Cc: STEricsson_nomadik_linux , > linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, > linux-arm-ker...@lists.infradead.org, patc...@linaro.org > Subj

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
...@lists.infradead.org, patc...@linaro.org Subject: Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp Message-ID: 4ffc563d.2080...@linaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Some of my comments are picky, but if it's going into Mainline, it should at least

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
Date: Tue, 10 Jul 2012 14:12:01 + From: Arnd Bergmann a...@arndb.de To: linux-arm-ker...@lists.infradead.org Cc: linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, Rajanikanth H.V rajanikanth...@stericsson.com, patc...@linaro.org Subject: Re: [PATCH] mfd: Implement

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Lee Jones
@@ -964,11 +966,13 @@ static int __devinit ab8500_btemp_probe(struct platform_device *pdev) { int irq, i, ret = 0; u8 val; - struct abx500_bm_plat_data *plat_data = pdev-dev.platform_data; I already told you about this. your previous comment was: No, it's meant to work

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Lee Jones
Some of my comments are picky, but if it's going into Mainline, it should at least look professional. You didn't CC the ST-Ericsson internal mailing list. Address is stericsson_nomadik_li...@list.st.com I'll do it for now, but please do so on your next submission. On 10/07/12 15:23,

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Rajanikanth H.V wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/power_supply/ab8500/btemp.txt > @@ -0,0 +1,54 @@ > +AB8500 Battery Termperature Monitor Driver > + > +AB8500 is a mixed signal multimedia and power management > +device comprising: power and

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Rajanikanth H.V wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/power_supply/ab8500/btemp.txt @@ -0,0 +1,54 @@ +AB8500 Battery Termperature Monitor Driver + +AB8500 is a mixed signal multimedia and power management +device comprising: power and energy

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Lee Jones
Some of my comments are picky, but if it's going into Mainline, it should at least look professional. You didn't CC the ST-Ericsson internal mailing list. Address is stericsson_nomadik_li...@list.st.com I'll do it for now, but please do so on your next submission. On 10/07/12 15:23,