Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or_hwpoison

2012-07-09 Thread Mel Gorman
On Mon, Jul 09, 2012 at 06:12:41PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Code was duplicated in two functions, clean it up. > > Signed-off-by: Wanpeng Li is_hugetlb_entry_migration() now returns true for hwpoisoned pages. In this block if

Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or_hwpoison

2012-07-09 Thread David Rientjes
On Mon, 9 Jul 2012, Wanpeng Li wrote: > From: Wanpeng Li > > Code was duplicated in two functions, clean it up. > > Signed-off-by: Wanpeng Li > --- > mm/hugetlb.c | 20 +--- > 1 files changed, 9 insertions(+), 11 deletions(-) Nack, this makes the code more convoluted then

Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or_hwpoison

2012-07-09 Thread David Rientjes
On Mon, 9 Jul 2012, Wanpeng Li wrote: From: Wanpeng Li l...@linux.vnet.ibm.com Code was duplicated in two functions, clean it up. Signed-off-by: Wanpeng Li liwp.li...@gmail.com --- mm/hugetlb.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) Nack, this

Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or_hwpoison

2012-07-09 Thread Mel Gorman
On Mon, Jul 09, 2012 at 06:12:41PM +0800, Wanpeng Li wrote: From: Wanpeng Li l...@linux.vnet.ibm.com Code was duplicated in two functions, clean it up. Signed-off-by: Wanpeng Li liwp.li...@gmail.com is_hugetlb_entry_migration() now returns true for hwpoisoned pages. In this block