Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c

2018-02-25 Thread Wei Wang
On 02/13/2018 06:16 PM, Michal Hocko wrote: On Fri 09-02-18 16:08:14, Wei Wang wrote: The PAGE_POISON macro is used in page_poison.c only, so avoid exporting it. Also remove the "mm/debug-pagealloc.c" related comment, which is obsolete. Why is this an improvement? I thought the whole point of p

Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c

2018-02-13 Thread Michal Hocko
On Fri 09-02-18 16:08:14, Wei Wang wrote: > The PAGE_POISON macro is used in page_poison.c only, so avoid exporting > it. Also remove the "mm/debug-pagealloc.c" related comment, which is > obsolete. Why is this an improvement? I thought the whole point of poison.h is to keep all the poison value a

Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c

2018-02-09 Thread Michael S. Tsirkin
On Fri, Feb 09, 2018 at 04:08:14PM +0800, Wei Wang wrote: > The PAGE_POISON macro is used in page_poison.c only, so avoid exporting > it. Also remove the "mm/debug-pagealloc.c" related comment, which is > obsolete. > > Signed-off-by: Wei Wang > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Michael