Re: [PATCH] namei: fix hardlink speeling error

2018-02-15 Thread Richard Guy Briggs 
On 2018-02-15 10:57, Philipp Hahn wrote:
> Hello,
> 
> Am 15.02.2018 um 03:28 schrieb Richard Guy Briggs:
> > Fix handlink to hardlink.
> 
> and introduce a new sp*el*ling error in the subject line ;-)

That one was quite intentional for ironic effect.  I could have added an
extra "e" for exaggerated effect if you like.  :-)

As for filedescriptor, that one I chose to leave alone due to 7 other
instances (out of ~700), while handlink stood alone (out of 126 hardlink
without and 77 with space) and was clearly misspelled in the context of
the source file.

I can file a followup patch to fix all "filedescriptor" in the same
patch if desired, but I'm not so sure that one is warranted.

> Philipp

- RGB

--
Richard Guy Briggs 
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

Re: [PATCH] namei: fix hardlink speeling error

2018-02-15 Thread Philipp Hahn 
Hello,

Am 15.02.2018 um 03:28 schrieb Richard Guy Briggs:
> Fix handlink to hardlink.

and introduce a new sp*el*ling error in the subject line ;-)

Philipp

Re: [PATCH] namei: fix hardlink speeling error

2018-02-14 Thread Matthew Wilcox 
On Wed, Feb 14, 2018 at 09:28:54PM -0500, Richard Guy Briggs wrote:
>* This ensures that not everyone will be able to create
> -  * handlink using the passed filedescriptor.
> +  * hardlink using the passed filedescriptor.
>*/

You're changing this line and you didn't feel the need to fix the
missing space or the missing article?