Re: [PATCH] net: phy: fix wrong mask to phy_modify()

2018-02-12 Thread David Miller
From: Ingo van Lil Date: Mon, 12 Feb 2018 12:02:52 +0100 > When forcing a specific link mode, the PHY driver must clear the > existing speed and duplex bits in BMCR while preserving some other > control bits. This logic was accidentally inverted with the introduction > of phy_modify(). > > Signe

Re: [PATCH] net: phy: fix wrong mask to phy_modify()

2018-02-12 Thread Andrew Lunn
On Mon, Feb 12, 2018 at 12:02:52PM +0100, Ingo van Lil wrote: > When forcing a specific link mode, the PHY driver must clear the > existing speed and duplex bits in BMCR while preserving some other > control bits. This logic was accidentally inverted with the introduction > of phy_modify(). > > Si