Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
Hello! On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van OostenryckAcked-by: Sergei Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/sh_eth.c > b/drivers/net/ethernet/renesas/sh_eth.c > index b6b90a631..0875a169f 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2454,7 +2454,7 @@ static void sh_eth_tx_timeout(struct net_device *ndev) > } > > /* Packet transmit function */ > -static int sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +static netdev_tx_t sh_eth_start_xmit(struct sk_buff *skb, struct net_device > *ndev) But aren't you violating 80-column limit? [...] MBR, Sergei
Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
Hello! On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Acked-by: Sergei Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/sh_eth.c > b/drivers/net/ethernet/renesas/sh_eth.c > index b6b90a631..0875a169f 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2454,7 +2454,7 @@ static void sh_eth_tx_timeout(struct net_device *ndev) > } > > /* Packet transmit function */ > -static int sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +static netdev_tx_t sh_eth_start_xmit(struct sk_buff *skb, struct net_device > *ndev) But aren't you violating 80-column limit? [...] MBR, Sergei
Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
On Tue, Apr 24, 2018 at 3:17 PM, Luc Van Oostenryckwrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type
On Tue, Apr 24, 2018 at 3:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds