Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-05 7:34 GMT+01:00 Rafał Miłecki : > On 3 January 2015 at 13:28, Rickard Strandqvist > wrote: >> 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >>> >>> 1) I gave you Ack for the changes >>> 2) You could drop "net: wireless: " or better use something Sedat proposed >> >> Nice, yes I miss the Ack :) >> >> I just got one more complaining about my subject-line in "net: wireless: " >> I use some sed call for this, so it's easy to fix. I will now remove that >> part hereinafter. > > Will you re-send this patch with a proper subject then, please? > > -- > Rafał Hi Rafał Ok, resent the patch. Just a thought about this naming. Now I have changed in radio.c and radio.h, what happens when I send another patch for other files in the same directory, the caption will then be identical. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-05 7:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: On 3 January 2015 at 13:28, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 22:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed Nice, yes I miss the Ack :) I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. Will you re-send this patch with a proper subject then, please? -- Rafał Hi Rafał Ok, resent the patch. Just a thought about this naming. Now I have changed in radio.c and radio.h, what happens when I send another patch for other files in the same directory, the caption will then be identical. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 3 January 2015 at 13:28, Rickard Strandqvist wrote: > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >> >> 1) I gave you Ack for the changes >> 2) You could drop "net: wireless: " or better use something Sedat proposed > > Nice, yes I miss the Ack :) > > I just got one more complaining about my subject-line in "net: wireless: " > I use some sed call for this, so it's easy to fix. I will now remove that > part hereinafter. Will you re-send this patch with a proper subject then, please? -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 3 January 2015 at 13:28, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 22:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed Nice, yes I miss the Ack :) I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. Will you re-send this patch with a proper subject then, please? -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-03 15:51 GMT+01:00 Sedat Dilek : > On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist > wrote: > [ ... ] >>> > I just got one more complaining about my subject-line in "net: wireless: " >>> > I use some sed call for this, so it's easy to fix. I will now remove that >>> > part hereinafter. >>> > I check in Documentation/ but did not find any clear info for this. >>> > >>> >>> The easiest way to make (sub)maintainers happy is to check the git-log... >>> >>> $ git log --oneline /path/to/file >>> >>> ...and look how other contributors labeled their patches. >>> >>> [1] is the 1st address to look at on how to submit patches to Linux-kernel. >>> To promote the good work of Greg, see [2,3] for a video and tutorial >>> on that topic, too. >>> >>> - Sedat - >>> >>> [1] >>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches >>> [2] https://www.youtube.com/watch?v=XXix80GCvpo >>> [3] https://github.com/gregkh/kernel-tutorial >> >> >> >> Hi Sedat >> >> Thanks for the tip :) >> >> To bad with the audio in the video thow. Have read SubmittingPatches before. >> > > AFAICS there is another (earlier) video "Write and Submit your first > Linux kernel Patch" from FOSDEM 2010. > > For German readers I can recommend the book from [2] (no I get no > money for promotion). > > - Sedat - > > [1] https://www.youtube.com/watch?v=LLBrBBImJt4 > [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5- > >> >> But I have now added a line in my script that does a: >> >> git log -10 --oneline >> >> So I can at least see the other subjekt lines, and make adjustments if >> necessary. >> >> >> >> Kind regards >> Rickard Strandqvist Hi Good video! Wish I had seen this a year ago. Sorry, no German for me :) Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist wrote: [ ... ] >> > I just got one more complaining about my subject-line in "net: wireless: " >> > I use some sed call for this, so it's easy to fix. I will now remove that >> > part hereinafter. >> > I check in Documentation/ but did not find any clear info for this. >> > >> >> The easiest way to make (sub)maintainers happy is to check the git-log... >> >> $ git log --oneline /path/to/file >> >> ...and look how other contributors labeled their patches. >> >> [1] is the 1st address to look at on how to submit patches to Linux-kernel. >> To promote the good work of Greg, see [2,3] for a video and tutorial >> on that topic, too. >> >> - Sedat - >> >> [1] >> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches >> [2] https://www.youtube.com/watch?v=XXix80GCvpo >> [3] https://github.com/gregkh/kernel-tutorial > > > > Hi Sedat > > Thanks for the tip :) > > To bad with the audio in the video thow. Have read SubmittingPatches before. > AFAICS there is another (earlier) video "Write and Submit your first Linux kernel Patch" from FOSDEM 2010. For German readers I can recommend the book from [2] (no I get no money for promotion). - Sedat - [1] https://www.youtube.com/watch?v=LLBrBBImJt4 [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5- > > But I have now added a line in my script that does a: > > git log -10 --oneline > > So I can at least see the other subjekt lines, and make adjustments if > necessary. > > > > Kind regards > Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-03 14:19 GMT+01:00 Sedat Dilek : > > On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist > wrote: > > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : > >> > >> On 2 January 2015 at 18:46, Rickard Strandqvist > >> wrote: > >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : > >> >> > >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: > >> >> > On 2 January 2015 at 13:05, Rafał Miłecki wrote: > >> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist > >> >> >> wrote: > >> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used > >> >> >>> anywhere. > >> >> >>> > >> >> >>> This was partially found by using a static code analysis program > >> >> >>> called cppcheck. > >> >> >> > >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which > >> >> >> is not handled by b43legacy. Should be safe to drop this code (we > >> >> >> won't likely need it). > >> >> >> > >> >> >> Ack > >> >> > > >> >> > For future, we prefix patches with just a driver name. So this could > >> >> > be simply called > >> >> > b43legacy: radio.c: Remove unused function > >> >> > > >> >> > >> >> Alternatively... > >> >> > >> >> "b43legacy: Remove unused function in radio.c" > >> >> > >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck > >> >> to get such stuff? > >> >> > >> >> - Sedat - > >> >> > >> >> [1] https://lkml.org/lkml/2015/1/2/51 > >> > > >> > > >> > > >> > Hi Rafal and Sedat > >> > > >> > Rafal do you mean I should remove the entire b43legacy part? > >> > >> 1) I gave you Ack for the changes > >> 2) You could drop "net: wireless: " or better use something Sedat proposed > >> > >> -- > >> Rafał > > > > > > > > Hi > > > > Nice, yes I miss the Ack :) > > > > I just got one more complaining about my subject-line in "net: wireless: " > > I use some sed call for this, so it's easy to fix. I will now remove that > > part hereinafter. > > I check in Documentation/ but did not find any clear info for this. > > > > The easiest way to make (sub)maintainers happy is to check the git-log... > > $ git log --oneline /path/to/file > > ...and look how other contributors labeled their patches. > > [1] is the 1st address to look at on how to submit patches to Linux-kernel. > To promote the good work of Greg, see [2,3] for a video and tutorial > on that topic, too. > > - Sedat - > > [1] > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches > [2] https://www.youtube.com/watch?v=XXix80GCvpo > [3] https://github.com/gregkh/kernel-tutorial Hi Sedat Thanks for the tip :) To bad with the audio in the video thow. Have read SubmittingPatches before. But I have now added a line in my script that does a: git log -10 --oneline So I can at least see the other subjekt lines, and make adjustments if necessary. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist wrote: > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : >> >> On 2 January 2015 at 18:46, Rickard Strandqvist >> wrote: >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : >> >> >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: >> >> > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist >> >> >> wrote: >> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used >> >> >>> anywhere. >> >> >>> >> >> >>> This was partially found by using a static code analysis program >> >> >>> called cppcheck. >> >> >> >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> >> >> is not handled by b43legacy. Should be safe to drop this code (we >> >> >> won't likely need it). >> >> >> >> >> >> Ack >> >> > >> >> > For future, we prefix patches with just a driver name. So this could >> >> > be simply called >> >> > b43legacy: radio.c: Remove unused function >> >> > >> >> >> >> Alternatively... >> >> >> >> "b43legacy: Remove unused function in radio.c" >> >> >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck >> >> to get such stuff? >> >> >> >> - Sedat - >> >> >> >> [1] https://lkml.org/lkml/2015/1/2/51 >> > >> > >> > >> > Hi Rafal and Sedat >> > >> > Rafal do you mean I should remove the entire b43legacy part? >> >> 1) I gave you Ack for the changes >> 2) You could drop "net: wireless: " or better use something Sedat proposed >> >> -- >> Rafał > > > > Hi > > Nice, yes I miss the Ack :) > > I just got one more complaining about my subject-line in "net: wireless: " > I use some sed call for this, so it's easy to fix. I will now remove that > part hereinafter. > I check in Documentation/ but did not find any clear info for this. > The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-03 14:19 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 22:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: On 2 January 2015 at 18:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 13:14 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki zaj...@gmail.com wrote: On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function Alternatively... b43legacy: Remove unused function in radio.c BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51 Hi Rafal and Sedat Rafal do you mean I should remove the entire b43legacy part? 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed -- Rafał Hi Nice, yes I miss the Ack :) I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. I check in Documentation/ but did not find any clear info for this. The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial Hi Sedat Thanks for the tip :) To bad with the audio in the video thow. Have read SubmittingPatches before. But I have now added a line in my script that does a: git log -10 --oneline So I can at least see the other subjekt lines, and make adjustments if necessary. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: [ ... ] I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. I check in Documentation/ but did not find any clear info for this. The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial Hi Sedat Thanks for the tip :) To bad with the audio in the video thow. Have read SubmittingPatches before. AFAICS there is another (earlier) video Write and Submit your first Linux kernel Patch from FOSDEM 2010. For German readers I can recommend the book from [2] (no I get no money for promotion). - Sedat - [1] https://www.youtube.com/watch?v=LLBrBBImJt4 [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5- But I have now added a line in my script that does a: git log -10 --oneline So I can at least see the other subjekt lines, and make adjustments if necessary. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
2015-01-03 15:51 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: [ ... ] I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. I check in Documentation/ but did not find any clear info for this. The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial Hi Sedat Thanks for the tip :) To bad with the audio in the video thow. Have read SubmittingPatches before. AFAICS there is another (earlier) video Write and Submit your first Linux kernel Patch from FOSDEM 2010. For German readers I can recommend the book from [2] (no I get no money for promotion). - Sedat - [1] https://www.youtube.com/watch?v=LLBrBBImJt4 [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5- But I have now added a line in my script that does a: git log -10 --oneline So I can at least see the other subjekt lines, and make adjustments if necessary. Kind regards Rickard Strandqvist Hi Good video! Wish I had seen this a year ago. Sorry, no German for me :) Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 22:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: On 2 January 2015 at 18:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 13:14 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki zaj...@gmail.com wrote: On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function Alternatively... b43legacy: Remove unused function in radio.c BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51 Hi Rafal and Sedat Rafal do you mean I should remove the entire b43legacy part? 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed -- Rafał Hi Nice, yes I miss the Ack :) I just got one more complaining about my subject-line in net: wireless: I use some sed call for this, so it's easy to fix. I will now remove that part hereinafter. I check in Documentation/ but did not find any clear info for this. The easiest way to make (sub)maintainers happy is to check the git-log... $ git log --oneline /path/to/file ...and look how other contributors labeled their patches. [1] is the 1st address to look at on how to submit patches to Linux-kernel. To promote the good work of Greg, see [2,3] for a video and tutorial on that topic, too. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches [2] https://www.youtube.com/watch?v=XXix80GCvpo [3] https://github.com/gregkh/kernel-tutorial -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 2 January 2015 at 18:46, Rickard Strandqvist wrote: > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: >> > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> >> On 1 January 2015 at 16:46, Rickard Strandqvist >> >> wrote: >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used >> >>> anywhere. >> >>> >> >>> This was partially found by using a static code analysis program >> >>> called cppcheck. >> >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> >> is not handled by b43legacy. Should be safe to drop this code (we >> >> won't likely need it). >> >> >> >> Ack >> > >> > For future, we prefix patches with just a driver name. So this could >> > be simply called >> > b43legacy: radio.c: Remove unused function >> > >> >> Alternatively... >> >> "b43legacy: Remove unused function in radio.c" >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck >> to get such stuff? >> >> - Sedat - >> >> [1] https://lkml.org/lkml/2015/1/2/51 > > > > Hi Rafal and Sedat > > Rafal do you mean I should remove the entire b43legacy part? 1) I gave you Ack for the changes 2) You could drop "net: wireless: " or better use something Sedat proposed -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> On 1 January 2015 at 16:46, Rickard Strandqvist >> wrote: >>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >>> >>> This was partially found by using a static code analysis program called >>> cppcheck. >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> is not handled by b43legacy. Should be safe to drop this code (we >> won't likely need it). >> >> Ack > > For future, we prefix patches with just a driver name. So this could > be simply called > b43legacy: radio.c: Remove unused function > Alternatively... "b43legacy: Remove unused function in radio.c" BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 2 January 2015 at 13:05, Rafał Miłecki wrote: > On 1 January 2015 at 16:46, Rickard Strandqvist > wrote: >> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >> >> This was partially found by using a static code analysis program called >> cppcheck. > > It seems to be for A-PHY based hardware (with 0x2060 radio id) which > is not handled by b43legacy. Should be safe to drop this code (we > won't likely need it). > > Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 1 January 2015 at 16:46, Rickard Strandqvist wrote: > Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki zaj...@gmail.com wrote: On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function Alternatively... b43legacy: Remove unused function in radio.c BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function
On 2 January 2015 at 18:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 13:14 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki zaj...@gmail.com wrote: On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack For future, we prefix patches with just a driver name. So this could be simply called b43legacy: radio.c: Remove unused function Alternatively... b43legacy: Remove unused function in radio.c BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51 Hi Rafal and Sedat Rafal do you mean I should remove the entire b43legacy part? 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
