Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: > On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > > depend on this. > > Thanks. But then a NFC_DEBUG symbol needs to be added, because now the > DEBUG macro will never be set, won't it? Probably right. I think all the nfc_dev_ uses are unsightly too. Almost all the nfc_dev_dbg uses are functdion enter/leave logging and should be done via the function tracer. I'll submit some patches for that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG macro will never be set, won't it? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be > any nfc code that uses a DEBUG macro. This line can safely be removed. [] > diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile [] > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. [] diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile [] -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG macro will never be set, won't it? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] nfc: Remove useless Makefile line
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG macro will never be set, won't it? Probably right. I think all the nfc_dev_level uses are unsightly too. Almost all the nfc_dev_dbg uses are functdion enter/leave logging and should be done via the function tracer. I'll submit some patches for that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
