Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-17 Thread Rob Herring
On Thu, Nov 16, 2017 at 8:44 PM, Stephen Boyd wrote: > On 11/10, Randy Dunlap wrote: >> On 11/10/2017 05:45 PM, Stephen Boyd wrote: >> > It isn't clear if this function of_node_put()s the 'from' >> > argument, or the node it finds in the search. Clearly indicate >> > which

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-17 Thread Rob Herring
On Thu, Nov 16, 2017 at 8:44 PM, Stephen Boyd wrote: > On 11/10, Randy Dunlap wrote: >> On 11/10/2017 05:45 PM, Stephen Boyd wrote: >> > It isn't clear if this function of_node_put()s the 'from' >> > argument, or the node it finds in the search. Clearly indicate >> > which variable is touched. >>

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-16 Thread Stephen Boyd
On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Signed-off-by: Stephen Boyd >

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-16 Thread Stephen Boyd
On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Signed-off-by: Stephen Boyd > > --- > >

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-10 Thread Randy Dunlap
On 11/10/2017 05:45 PM, Stephen Boyd wrote: > It isn't clear if this function of_node_put()s the 'from' > argument, or the node it finds in the search. Clearly indicate > which variable is touched. > > Signed-off-by: Stephen Boyd > --- > drivers/of/base.c | 2 +- > 1 file

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-10 Thread Randy Dunlap
On 11/10/2017 05:45 PM, Stephen Boyd wrote: > It isn't clear if this function of_node_put()s the 'from' > argument, or the node it finds in the search. Clearly indicate > which variable is touched. > > Signed-off-by: Stephen Boyd > --- > drivers/of/base.c | 2 +- > 1 file changed, 1