Re: [PATCH] perf report: show sort_order in title

2017-03-14 Thread Du, Changbin
On Tue, Mar 14, 2017 at 10:04:16AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 14, 2017 at 10:16:44AM +0800, Du, Changbin escreveu: > > On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > > But then, while testing, > > > > Before: > > > > $ perf report > > >

Re: [PATCH] perf report: show sort_order in title

2017-03-14 Thread Du, Changbin
On Tue, Mar 14, 2017 at 10:04:16AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 14, 2017 at 10:16:44AM +0800, Du, Changbin escreveu: > > On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > > But then, while testing, > > > > Before: > > > > $ perf report > > >

Re: [PATCH] perf report: show sort_order in title

2017-03-14 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 14, 2017 at 10:16:44AM +0800, Du, Changbin escreveu: > On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > But then, while testing, > > Before: > > $ perf report > > Samples: 405 of event 'cycles', Event count (approx.): 101733003 > > Overhead

Re: [PATCH] perf report: show sort_order in title

2017-03-14 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 14, 2017 at 10:16:44AM +0800, Du, Changbin escreveu: > On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > But then, while testing, > > Before: > > $ perf report > > Samples: 405 of event 'cycles', Event count (approx.): 101733003 > > Overhead

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Du, Changbin
On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > I'll just rename this to use the tools/perf/ style for such functions, > > making it: > > > > static int hists__scnprintf_sort_fields(hists, buf, size) > > But then, while testing, > > Before: > > $ perf

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Du, Changbin
On Mon, Mar 13, 2017 at 11:57:18AM -0300, Arnaldo Carvalho de Melo wrote: > > I'll just rename this to use the tools/perf/ style for such functions, > > making it: > > > > static int hists__scnprintf_sort_fields(hists, buf, size) > > But then, while testing, > > Before: > > $ perf

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 13, 2017 at 11:47:14AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 13, 2017 at 04:36:35PM +0800, changbin...@intel.com escreveu: > > From: Changbin Du > > > > In the report, how does the data sort is a important info for > > analyser. Moreover, perf

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 13, 2017 at 11:47:14AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 13, 2017 at 04:36:35PM +0800, changbin...@intel.com escreveu: > > From: Changbin Du > > > > In the report, how does the data sort is a important info for > > analyser. Moreover, perf sometimes insert or

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 13, 2017 at 04:36:35PM +0800, changbin...@intel.com escreveu: > From: Changbin Du > > In the report, how does the data sort is a important info for > analyser. Moreover, perf sometimes insert or append sort fields > automatically. Thus user may confuse how it

Re: [PATCH] perf report: show sort_order in title

2017-03-13 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 13, 2017 at 04:36:35PM +0800, changbin...@intel.com escreveu: > From: Changbin Du > > In the report, how does the data sort is a important info for > analyser. Moreover, perf sometimes insert or append sort fields > automatically. Thus user may confuse how it sorts w/o reading > perf