Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
On 08/16/2016 01:58 AM, perr perr wrote: > On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski >wrote > > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > > Because chained_irq_enter() has already called chip->irq_mask() and > > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > > so it's not necessary to call chip->irq_*() here. > > > > > > Signed-off-by: perr > > > > > > --- > > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > > > > Looks correct so for the patch itself: > > Reviewed-by: Krzysztof Kozlowski > > > > However, your name "Perr" confuses me a little bit. For the > > Signed-off-by statement, as mentioned in > > Documentation/SubmittingPatches, a real name is required. The name > > should match the author. > > > > Would you be so kind as to use a full, real name? Unless Perr is your > > full, real name... then sorry for the trouble. > Perr Zhang is OK? > I'm from China. Perr is my first name in English. Yes, seems fine. Could you resend with updated name? Best regards, Krzysztof
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
On 08/16/2016 01:58 AM, perr perr wrote: > On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski > wrote > > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > > Because chained_irq_enter() has already called chip->irq_mask() and > > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > > so it's not necessary to call chip->irq_*() here. > > > > > > Signed-off-by: perr > > > > > > --- > > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > > > > Looks correct so for the patch itself: > > Reviewed-by: Krzysztof Kozlowski > > > > However, your name "Perr" confuses me a little bit. For the > > Signed-off-by statement, as mentioned in > > Documentation/SubmittingPatches, a real name is required. The name > > should match the author. > > > > Would you be so kind as to use a full, real name? Unless Perr is your > > full, real name... then sorry for the trouble. > Perr Zhang is OK? > I'm from China. Perr is my first name in English. Yes, seems fine. Could you resend with updated name? Best regards, Krzysztof
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Sent using Zoho Mail On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowskiwrote > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > Because chained_irq_enter() has already called chip->irq_mask() and > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > so it's not necessary to call chip->irq_*() here. > > > > Signed-off-by: perr > > > > --- > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > Looks correct so for the patch itself: > Reviewed-by: Krzysztof Kozlowski > > However, your name "Perr" confuses me a little bit. For the > Signed-off-by statement, as mentioned in > Documentation/SubmittingPatches, a real name is required. The name > should match the author. > > Would you be so kind as to use a full, real name? Unless Perr is your > full, real name... then sorry for the trouble. Perr Zhang is OK? I'm from China. Perr is my first name in English. > > Best regards, > Krzysztof > >
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Sent using Zoho Mail On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski wrote > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > Because chained_irq_enter() has already called chip->irq_mask() and > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > so it's not necessary to call chip->irq_*() here. > > > > Signed-off-by: perr > > > > --- > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > Looks correct so for the patch itself: > Reviewed-by: Krzysztof Kozlowski > > However, your name "Perr" confuses me a little bit. For the > Signed-off-by statement, as mentioned in > Documentation/SubmittingPatches, a real name is required. The name > should match the author. > > Would you be so kind as to use a full, real name? Unless Perr is your > full, real name... then sorry for the trouble. Perr Zhang is OK? I'm from China. Perr is my first name in English. > > Best regards, > Krzysztof > >
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr> > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > Looks correct so for the patch itself: Reviewed-by: Krzysztof Kozlowski However, your name "Perr" confuses me a little bit. For the Signed-off-by statement, as mentioned in Documentation/SubmittingPatches, a real name is required. The name should match the author. Would you be so kind as to use a full, real name? Unless Perr is your full, real name... then sorry for the trouble. Best regards, Krzysztof
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > Looks correct so for the patch itself: Reviewed-by: Krzysztof Kozlowski However, your name "Perr" confuses me a little bit. For the Signed-off-by statement, as mentioned in Documentation/SubmittingPatches, a real name is required. The name should match the author. Would you be so kind as to use a full, real name? Unless Perr is your full, real name... then sorry for the trouble. Best regards, Krzysztof
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Hi, 2016-08-15 19:17 GMT+09:00 perr: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > Indeed, nice finding. Thanks! Acked-by: Tomasz Figa Best regards, Tomasz
Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Hi, 2016-08-15 19:17 GMT+09:00 perr : > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: perr > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > Indeed, nice finding. Thanks! Acked-by: Tomasz Figa Best regards, Tomasz