Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 20:35 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 09:08:44AM -0700, Joe Perches wrote: > > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > > OK, I recall a discussion with Dan where he

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Dan Carpenter
On Thu, Jun 04, 2020 at 09:08:44AM -0700, Joe Perches wrote: > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > OK, I recall a discussion with Dan where he suggested that some things > > > that were not actually bug

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > OK, I recall a discussion with Dan where he suggested that some things > > > that were not actually bug fixes could also

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Dan Carpenter
On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > OK, I recall a discussion with Dan where he suggested that some things > that were not actually bug fixes could also merit a Fixes tag. But it's > probably better if he weighs in directly. I generally think Fixes should only be used

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 12:33 +0200, Julia Lawall wrote: > > > > On Thu, 4 Jun 2020, Joe Perches wrote: > > > > > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > > > Should Fixes also be used when the change will make it hard to port > > > >

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 12:33 +0200, Julia Lawall wrote: > > On Thu, 4 Jun 2020, Joe Perches wrote: > > > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > > Should Fixes also be used when the change will make it hard to port other > > > fixes over it? > > > > If it's a logic defect or

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > Should Fixes also be used when the change will make it hard to port other > > fixes over it? > > If it's a logic defect or regression that's being fixed, > shouldn't the logic defect or

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > Should Fixes also be used when the change will make it hard to port other > fixes over it? If it's a logic defect or regression that's being fixed, shouldn't the logic defect or regression be fixed as reasonably soon as possible? The

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > [] > > > Fixes means it fixes something that was wrong in that commit. > > > That's all. Whether syntactic or semantic or

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: [] > > Fixes means it fixes something that was wrong in that commit. > > That's all. Whether syntactic or semantic or regression or > > serious or not does not matter. It is

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Dan Carpenter
On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter wrote: > > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > > Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > > > > Christophe JAILLET writes: > > > > > > > > >

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-03 Thread Linus Walleij
On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter wrote: > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > > > Christophe JAILLET writes: > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for > > >

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-03 Thread Linus Walleij
On Sun, May 31, 2020 at 9:37 AM Christophe JAILLET wrote: > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl > registration") > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > 'pxa2xx_pinctrl_init()'. > However, the corresponding

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-01 Thread Dan Carpenter
On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > > Christophe JAILLET writes: > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for > > > pinctrl registration") > > > has turned a 'pinctrl_register()'

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-01 Thread Christophe JAILLET
Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : Christophe JAILLET writes: Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in 'pxa2xx_pinctrl_init()'. However, the corresponding

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-01 Thread Robert Jarzmik
Christophe JAILLET writes: > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl > registration") > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > 'pxa2xx_pinctrl_init()'. > However, the corresponding 'pinctrl_unregister()' call in >