Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist

2018-02-08 Thread Pali Rohár 
On Thursday 08 February 2018 01:12:26 Alexander Abrosimov wrote:
> Fixed a mistake in which several entries were duplicated in the DMI list
> from the below commit
> fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
> 
> Signed-off-by: Alexander Abrosimov 

Reviewed-by: Pali Rohár 

> ---
>  drivers/platform/x86/dell-laptop.c | 18 --
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c 
> b/drivers/platform/x86/dell-laptop.c
> index a7b141992cb3..a66a6a6e47b9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] 
> __initconst = {
>   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>   DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
>   },
>   },
>   {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> - },
> - },
> - {
>   .ident = "Dell Computer Corporation",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
>   DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
>   },

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: PGP signature

Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist

2018-02-08 Thread Andy Shevchenko 
On Thu, Feb 8, 2018 at 12:12 AM, Alexander Abrosimov
 wrote:
> Fixed a mistake in which several entries were duplicated in the DMI list
> from the below commit
> fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
>

Pushed to my review and testing queue, thanks!

(Would be material for v4.17 cycle)

> Signed-off-by: Alexander Abrosimov 
> ---
>  drivers/platform/x86/dell-laptop.c | 18 --
>  1 file changed, 18 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c 
> b/drivers/platform/x86/dell-laptop.c
> index a7b141992cb3..a66a6a6e47b9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] 
> __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> },
> },
> {
> -   .matches = {
> -   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -   DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> -   },
> -   },
> -   {
> -   .matches = {
> -   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -   DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> -   },
> -   },
> -   {
> -   .matches = {
> -   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -   DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> -   },
> -   },
> -   {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer 
> Corporation"),
> DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
> },
> --
> 2.13.6
>



-- 
With Best Regards,
Andy Shevchenko