> config INFINIBAND_QEDR
> - tristate "QLogic qede RoCE sources [debug]"
> + bool "QLogic qede RoCE sources [debug]"
Given that the qedr submission is going to turn this back into a tristate,
are you certain this is a good thing [from compilation coverage perspective]?
> - if
On Thursday, October 13, 2016 10:44:36 AM CEST Mintz, Yuval wrote:
> > > > > While I don't mind, you could have argued is that we're not
> > > > > removing enough, not too much.
> > > > > I.e., perhaps the rdma_msix_* fields should also have been
> > > > > ifdef-ed instead. [in which case this solu
> > > > While I don't mind, you could have argued is that we're not
> > > > removing enough, not too much.
> > > > I.e., perhaps the rdma_msix_* fields should also have been
> > > > ifdef-ed instead. [in which case this solution would not have
> > > > worked]
> > >
> > > That would add even more #i
On Thursday, October 13, 2016 9:34:41 AM CEST Mintz, Yuval wrote:
>
> > > > - if (cond)
> > > > + if (IS_ENABLED(CONFIG_INFINIBAND_QEDR) && cond)
> > > > qed_rdma_dpm_bar(p_hwfn, p_ptt);
> > >
> > > Why not simply fix the qed_roce.h empty implementation?
> > > - if (cond)
> > > + if (IS_ENABLED(CONFIG_INFINIBAND_QEDR) && cond)
> > > qed_rdma_dpm_bar(p_hwfn, p_ptt);
> >
> > Why not simply fix the qed_roce.h empty implementation?
>
> Mainly for consistency: we have a couple of interfaces that are called from
> the
On Thursday, October 13, 2016 8:50:21 AM CEST Mintz, Yuval wrote:
> > config INFINIBAND_QEDR
> > - tristate "QLogic qede RoCE sources [debug]"
> > + bool "QLogic qede RoCE sources [debug]"
>
> Given that the qedr submission is going to turn this back into a tristate,
> are you certain this is
6 matches
Mail list logo
