Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Michal Simek
Hi Mark, On 02/10/2014 12:49 PM, Mark Brown wrote: > On Mon, Feb 10, 2014 at 11:53:38AM +0100, Lars-Peter Clausen wrote: >> On 02/10/2014 11:46 AM, Michal Simek wrote: >>> Check if regs are readable. > >>> + if (!regmap_readable(map, reg)) >>> + return -EIO; > >> This will cause

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Mark Brown
On Mon, Feb 10, 2014 at 11:53:38AM +0100, Lars-Peter Clausen wrote: > On 02/10/2014 11:46 AM, Michal Simek wrote: > >Check if regs are readable. > >+if (!regmap_readable(map, reg)) > >+return -EIO; > This will cause issues with devices where registers are writable, > but not

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Michal Simek
Hi Lars, On 02/10/2014 11:53 AM, Lars-Peter Clausen wrote: > On 02/10/2014 11:46 AM, Michal Simek wrote: >> Check if regs are readable. >> >> Signed-off-by: Michal Simek >> --- >> >> drivers/base/regmap/regmap.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Lars-Peter Clausen
On 02/10/2014 11:46 AM, Michal Simek wrote: Check if regs are readable. Signed-off-by: Michal Simek --- drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 6a19515..7569dfc 100644 ---

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Lars-Peter Clausen
On 02/10/2014 11:46 AM, Michal Simek wrote: Check if regs are readable. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Michal Simek
Hi Lars, On 02/10/2014 11:53 AM, Lars-Peter Clausen wrote: On 02/10/2014 11:46 AM, Michal Simek wrote: Check if regs are readable. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Mark Brown
On Mon, Feb 10, 2014 at 11:53:38AM +0100, Lars-Peter Clausen wrote: On 02/10/2014 11:46 AM, Michal Simek wrote: Check if regs are readable. +if (!regmap_readable(map, reg)) +return -EIO; This will cause issues with devices where registers are writable, but not readable, but

Re: [PATCH] regmap: Check readable regs in _regmap_read

2014-02-10 Thread Michal Simek
Hi Mark, On 02/10/2014 12:49 PM, Mark Brown wrote: On Mon, Feb 10, 2014 at 11:53:38AM +0100, Lars-Peter Clausen wrote: On 02/10/2014 11:46 AM, Michal Simek wrote: Check if regs are readable. + if (!regmap_readable(map, reg)) + return -EIO; This will cause issues with devices