Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata->dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps->desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? The dvfs_step_20mV will only effect for the control through DVFS (PWM). The voltage control an voltage base register will till use the 10mV steps. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver
On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... > + if (pdata->dvfs_step_20mV) > + control |= TPS51632_DVFS_STEP_20; > + tps->desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver
On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? The dvfs_step_20mV will only effect for the control through DVFS (PWM). The voltage control an voltage base register will till use the 10mV steps. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
