Re: [PATCH] rtc: m41t80: fix fall-through annotation

2018-10-04 Thread Gustavo A. R. Silva
On 10/4/18 2:53 PM, Alexandre Belloni wrote: > Hi, > > On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote: >> Replace "Fall" with a proper "Fall through" annotation. >> >> This fix is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough >> > > Can we agree that this is

Re: [PATCH] rtc: m41t80: fix fall-through annotation

2018-10-04 Thread Gustavo A. R. Silva
On 10/4/18 2:53 PM, Alexandre Belloni wrote: > Hi, > > On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote: >> Replace "Fall" with a proper "Fall through" annotation. >> >> This fix is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough >> > > Can we agree that this is

Re: [PATCH] rtc: m41t80: fix fall-through annotation

2018-10-04 Thread Alexandre Belloni
Hi, On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote: > Replace "Fall" with a proper "Fall through" annotation. > > This fix is part of the ongoing efforts to enabling > -Wimplicit-fallthrough > Can we agree that this is absolutely not a fix? I don't wan't to have that needlessly

Re: [PATCH] rtc: m41t80: fix fall-through annotation

2018-10-04 Thread Alexandre Belloni
Hi, On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote: > Replace "Fall" with a proper "Fall through" annotation. > > This fix is part of the ongoing efforts to enabling > -Wimplicit-fallthrough > Can we agree that this is absolutely not a fix? I don't wan't to have that needlessly