Re: [PATCH] rtc: xilinx: Fix calibval variable type
On 08/10/2019 16:25:41+0200, Michal Simek wrote: > From: Srinivas Goud > > This patch fixes the warnings reported by static code analysis. > Updated calibval variable type to unsigned type from signed. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > --- > > drivers/rtc/rtc-zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH] rtc: xilinx: Fix calibval variable type
On 08. 10. 19 16:31, Alexandre Belloni wrote: > Hi, > > On 08/10/2019 16:25:41+0200, Michal Simek wrote: >> From: Srinivas Goud >> >> This patch fixes the warnings reported by static code analysis. >> Updated calibval variable type to unsigned type from signed. >> >> Signed-off-by: Srinivas Goud >> Signed-off-by: Michal Simek >> --- >> >> drivers/rtc/rtc-zynqmp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c >> index 2c762757fb54..da0dbea8def3 100644 >> --- a/drivers/rtc/rtc-zynqmp.c >> +++ b/drivers/rtc/rtc-zynqmp.c >> @@ -44,7 +44,7 @@ struct xlnx_rtc_dev { >> void __iomem*reg_base; >> int alarm_irq; >> int sec_irq; >> -int calibval; >> +unsigned intcalibval; > > Note that ideally, this varialbe should be removed and replaced by > .read_offset and .set_offset callbacks so userspace can properly > recalibrate the crystal instead of relying on a static value inside the > device tree. Thanks for letting me know. We will look at it. It should be patch on the top anyway. Thanks, Michal
Re: [PATCH] rtc: xilinx: Fix calibval variable type
Hi, On 08/10/2019 16:25:41+0200, Michal Simek wrote: > From: Srinivas Goud > > This patch fixes the warnings reported by static code analysis. > Updated calibval variable type to unsigned type from signed. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > --- > > drivers/rtc/rtc-zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c > index 2c762757fb54..da0dbea8def3 100644 > --- a/drivers/rtc/rtc-zynqmp.c > +++ b/drivers/rtc/rtc-zynqmp.c > @@ -44,7 +44,7 @@ struct xlnx_rtc_dev { > void __iomem*reg_base; > int alarm_irq; > int sec_irq; > - int calibval; > + unsigned intcalibval; Note that ideally, this varialbe should be removed and replaced by .read_offset and .set_offset callbacks so userspace can properly recalibrate the crystal instead of relying on a static value inside the device tree. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com