Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-05 Thread Wanpeng Li 
On Thu, Mar 05, 2015 at 09:24:05AM +, Juri Lelli wrote:
>On 05/03/15 01:38, Wanpeng Li wrote:
>> Ping Juri,
>
>Yeah, I looked at it this morning. Looks good, thanks!
>
>> On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
>>> After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter 
>>> modification handling"), deadline task throttled status is cleared
>>> each time switch from dl, so throttled status always unset when 
>>> switch back, there is no need to check throttled status, this patch 
>>> drop the check.
>>>
>>> Signed-off-by: Wanpeng Li 
>
>Acked-by: Juri Lelli 

Thanks for your review. ;-)

Regards,
Wanpeng Li 

>
>>> ---
>>> kernel/sched/deadline.c | 8 
>>> 1 file changed, 8 deletions(-)
>>>
>>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>>> index ca391c0..cfb8fa7 100644
>>> --- a/kernel/sched/deadline.c
>>> +++ b/kernel/sched/deadline.c
>>> @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
>>> task_struct *p)
>>> {
>>> int check_resched = 1;
>>>
>>> -   /*
>>> -* If p is throttled, don't consider the possibility
>>> -* of preempting rq->curr, the check will be done right
>>> -* after its runtime will get replenished.
>>> -*/
>>> -   if (unlikely(p->dl.dl_throttled))
>>> -   return;
>>> -
>>> if (task_on_rq_queued(p) && rq->curr != p) {
>>> #ifdef CONFIG_SMP
>>> if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>>> -- 
>>> 1.9.1
>> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-05 Thread Juri Lelli 
On 05/03/15 01:38, Wanpeng Li wrote:
> Ping Juri,

Yeah, I looked at it this morning. Looks good, thanks!

> On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
>> After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter 
>> modification handling"), deadline task throttled status is cleared
>> each time switch from dl, so throttled status always unset when 
>> switch back, there is no need to check throttled status, this patch 
>> drop the check.
>>
>> Signed-off-by: Wanpeng Li 

Acked-by: Juri Lelli 

>> ---
>> kernel/sched/deadline.c | 8 
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>> index ca391c0..cfb8fa7 100644
>> --- a/kernel/sched/deadline.c
>> +++ b/kernel/sched/deadline.c
>> @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
>> task_struct *p)
>> {
>>  int check_resched = 1;
>>
>> -/*
>> - * If p is throttled, don't consider the possibility
>> - * of preempting rq->curr, the check will be done right
>> - * after its runtime will get replenished.
>> - */
>> -if (unlikely(p->dl.dl_throttled))
>> -return;
>> -
>>  if (task_on_rq_queued(p) && rq->curr != p) {
>> #ifdef CONFIG_SMP
>>  if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>> -- 
>> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-05 Thread Juri Lelli 
On 05/03/15 01:38, Wanpeng Li wrote:
 Ping Juri,

Yeah, I looked at it this morning. Looks good, thanks!

 On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
 After commit 40767b0dc768 (sched/deadline: Fix deadline parameter 
 modification handling), deadline task throttled status is cleared
 each time switch from dl, so throttled status always unset when 
 switch back, there is no need to check throttled status, this patch 
 drop the check.

 Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com

Acked-by: Juri Lelli juri.le...@arm.com

 ---
 kernel/sched/deadline.c | 8 
 1 file changed, 8 deletions(-)

 diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
 index ca391c0..cfb8fa7 100644
 --- a/kernel/sched/deadline.c
 +++ b/kernel/sched/deadline.c
 @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
 task_struct *p)
 {
  int check_resched = 1;

 -/*
 - * If p is throttled, don't consider the possibility
 - * of preempting rq-curr, the check will be done right
 - * after its runtime will get replenished.
 - */
 -if (unlikely(p-dl.dl_throttled))
 -return;
 -
  if (task_on_rq_queued(p)  rq-curr != p) {
 #ifdef CONFIG_SMP
  if (p-nr_cpus_allowed  1  rq-dl.overloaded 
 -- 
 1.9.1
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-05 Thread Wanpeng Li 
On Thu, Mar 05, 2015 at 09:24:05AM +, Juri Lelli wrote:
On 05/03/15 01:38, Wanpeng Li wrote:
 Ping Juri,

Yeah, I looked at it this morning. Looks good, thanks!

 On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
 After commit 40767b0dc768 (sched/deadline: Fix deadline parameter 
 modification handling), deadline task throttled status is cleared
 each time switch from dl, so throttled status always unset when 
 switch back, there is no need to check throttled status, this patch 
 drop the check.

 Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com

Acked-by: Juri Lelli juri.le...@arm.com

Thanks for your review. ;-)

Regards,
Wanpeng Li 


 ---
 kernel/sched/deadline.c | 8 
 1 file changed, 8 deletions(-)

 diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
 index ca391c0..cfb8fa7 100644
 --- a/kernel/sched/deadline.c
 +++ b/kernel/sched/deadline.c
 @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
 task_struct *p)
 {
 int check_resched = 1;

 -   /*
 -* If p is throttled, don't consider the possibility
 -* of preempting rq-curr, the check will be done right
 -* after its runtime will get replenished.
 -*/
 -   if (unlikely(p-dl.dl_throttled))
 -   return;
 -
 if (task_on_rq_queued(p)  rq-curr != p) {
 #ifdef CONFIG_SMP
 if (p-nr_cpus_allowed  1  rq-dl.overloaded 
 -- 
 1.9.1
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-04 Thread Wanpeng Li 
Ping Juri,
On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
>After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter 
>modification handling"), deadline task throttled status is cleared
>each time switch from dl, so throttled status always unset when 
>switch back, there is no need to check throttled status, this patch 
>drop the check.
>
>Signed-off-by: Wanpeng Li 
>---
> kernel/sched/deadline.c | 8 
> 1 file changed, 8 deletions(-)
>
>diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>index ca391c0..cfb8fa7 100644
>--- a/kernel/sched/deadline.c
>+++ b/kernel/sched/deadline.c
>@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
>task_struct *p)
> {
>   int check_resched = 1;
> 
>-  /*
>-   * If p is throttled, don't consider the possibility
>-   * of preempting rq->curr, the check will be done right
>-   * after its runtime will get replenished.
>-   */
>-  if (unlikely(p->dl.dl_throttled))
>-  return;
>-
>   if (task_on_rq_queued(p) && rq->curr != p) {
> #ifdef CONFIG_SMP
>   if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>-- 
>1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl

2015-03-04 Thread Wanpeng Li 
Ping Juri,
On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote:
After commit 40767b0dc768 (sched/deadline: Fix deadline parameter 
modification handling), deadline task throttled status is cleared
each time switch from dl, so throttled status always unset when 
switch back, there is no need to check throttled status, this patch 
drop the check.

Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com
---
 kernel/sched/deadline.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ca391c0..cfb8fa7 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct 
task_struct *p)
 {
   int check_resched = 1;
 
-  /*
-   * If p is throttled, don't consider the possibility
-   * of preempting rq-curr, the check will be done right
-   * after its runtime will get replenished.
-   */
-  if (unlikely(p-dl.dl_throttled))
-  return;
-
   if (task_on_rq_queued(p)  rq-curr != p) {
 #ifdef CONFIG_SMP
   if (p-nr_cpus_allowed  1  rq-dl.overloaded 
-- 
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/