Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Geert > > This driver is called from shdma-base.c. > > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. > > > > 1) this "slave_id" came from shdma_ops::set_slave > > and, it is using "int" > > 2) above drivers have same xxx_find_slave(), > > they are using "int". > > (this

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Morimoto-san, On Fri, Jan 24, 2014 at 9:18 AM, Kuninori Morimoto wrote: >> > + if (slave_id >= AUDMAPP_SLAVE_NUMBER) >> >> So slave_id should be unsigned int, too, and AUDMAPP_SLAVE_NUMBER >> too ("29U"). > > Hmm... > This driver is called from shdma-base.c. > And

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Geert Thank you for your review > > --- a/drivers/dma/sh/Kconfig > > +++ b/drivers/dma/sh/Kconfig > > @@ -29,6 +29,12 @@ config RCAR_HPB_DMAE > > help > > Enable support for the Renesas R-Car series DMA controllers. > > > > +config RCAR_AUDMAC_PP > > + tristate

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Geert Thank you for your review --- a/drivers/dma/sh/Kconfig +++ b/drivers/dma/sh/Kconfig @@ -29,6 +29,12 @@ config RCAR_HPB_DMAE help Enable support for the Renesas R-Car series DMA controllers. +config RCAR_AUDMAC_PP + tristate Renesas R-Car Audio

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Morimoto-san, On Fri, Jan 24, 2014 at 9:18 AM, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: + if (slave_id = AUDMAPP_SLAVE_NUMBER) So slave_id should be unsigned int, too, and AUDMAPP_SLAVE_NUMBER too (29U). Hmm... This driver is called from shdma-base.c. And

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Geert This driver is called from shdma-base.c. And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. 1) this slave_id came from shdma_ops::set_slave and, it is using int 2) above drivers have same xxx_find_slave(), they are using int. (this driver is based on

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Morimoto-san, On Fri, Jan 24, 2014 at 3:32 AM, Kuninori Morimoto wrote: > --- a/drivers/dma/sh/Kconfig > +++ b/drivers/dma/sh/Kconfig > @@ -29,6 +29,12 @@ config RCAR_HPB_DMAE > help > Enable support for the Renesas R-Car series DMA controllers. > > +config RCAR_AUDMAC_PP >

Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

Hi Morimoto-san, On Fri, Jan 24, 2014 at 3:32 AM, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: --- a/drivers/dma/sh/Kconfig +++ b/drivers/dma/sh/Kconfig @@ -29,6 +29,12 @@ config RCAR_HPB_DMAE help Enable support for the Renesas R-Car series DMA controllers.