Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 13:51:19, Cristopher Lameter wrote: > On Fri, 16 Nov 2018, Masahiro Yamada wrote: > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index 918f374..d395c73 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -329,7 +329,7 @@ static

Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 13:51:19, Cristopher Lameter wrote: > On Fri, 16 Nov 2018, Masahiro Yamada wrote: > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index 918f374..d395c73 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -329,7 +329,7 @@ static

Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Christopher Lameter
On Fri, 16 Nov 2018, Masahiro Yamada wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 918f374..d395c73 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -329,7 +329,7 @@ static __always_inline enum kmalloc_cache_type > kmalloc_type(gfp_t flags) >

Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Christopher Lameter
On Fri, 16 Nov 2018, Masahiro Yamada wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 918f374..d395c73 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -329,7 +329,7 @@ static __always_inline enum kmalloc_cache_type > kmalloc_type(gfp_t flags) >

Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 14:40:29, Masahiro Yamada wrote: > Sparse reports: > ./include/linux/slab.h:332:43: warning: dubious: x & !y JFYI this has been discussed here http://lkml.kernel.org/r/20181105204000.129023-1-bvanass...@acm.org > Signed-off-by: Masahiro Yamada > --- > > include/linux/slab.h |

Re: [PATCH] slab: fix 'dubious: x & !y' warning from Sparse

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 14:40:29, Masahiro Yamada wrote: > Sparse reports: > ./include/linux/slab.h:332:43: warning: dubious: x & !y JFYI this has been discussed here http://lkml.kernel.org/r/20181105204000.129023-1-bvanass...@acm.org > Signed-off-by: Masahiro Yamada > --- > > include/linux/slab.h |