Re: [PATCH] splice: partial write handling fix

2007-03-15 Thread Dmitriy Monakhov
Jens Axboe <[EMAIL PROTECTED]> writes: > On Wed, Mar 14 2007, Dmitriy Monakhov wrote: >> currently if partial write has happened while ->commit_write() then page >> wasn't marked as accessed and rebalanced. > > The ->commit_write() return values aren't very well designed imho. Is > your fix

Re: [PATCH] splice: partial write handling fix

2007-03-15 Thread Jens Axboe
On Wed, Mar 14 2007, Dmitriy Monakhov wrote: > currently if partial write has happened while ->commit_write() then page > wasn't marked as accessed and rebalanced. The ->commit_write() return values aren't very well designed imho. Is your fix correct getting the pipe_to_file() return value

Re: [PATCH] splice: partial write handling fix

2007-03-15 Thread Jens Axboe
On Wed, Mar 14 2007, Dmitriy Monakhov wrote: currently if partial write has happened while -commit_write() then page wasn't marked as accessed and rebalanced. The -commit_write() return values aren't very well designed imho. Is your fix correct getting the pipe_to_file() return value correct

Re: [PATCH] splice: partial write handling fix

2007-03-15 Thread Dmitriy Monakhov
Jens Axboe [EMAIL PROTECTED] writes: On Wed, Mar 14 2007, Dmitriy Monakhov wrote: currently if partial write has happened while -commit_write() then page wasn't marked as accessed and rebalanced. The -commit_write() return values aren't very well designed imho. Is your fix correct getting