Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 02:25:57PM +0100, Phil Elwell wrote: > > > On 10/08/2017 12:24, Dan Carpenter wrote: > > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > >> On 10/08/2017 11:21, Dan Carpenter wrote: > >>> The original patch did not go through the normal review process... > >

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Phil Elwell
On 10/08/2017 12:24, Dan Carpenter wrote: > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: >> On 10/08/2017 11:21, Dan Carpenter wrote: >>> The original patch did not go through the normal review process... >>> >>> On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: I'

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 02:24:51PM +0300, Dan Carpenter wrote: > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > > On 10/08/2017 11:21, Dan Carpenter wrote: > > > The original patch did not go through the normal review process... > > > > > > On Tue, Aug 08, 2017 at 01:05:02PM +0100,

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > On 10/08/2017 11:21, Dan Carpenter wrote: > > The original patch did not go through the normal review process... > > > > On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: > >> I'm all for fixing memory leaks, but freeing a b

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > > This label name is out of date. There is a later error path where > > vc_vchi_audio_init() fails and we leak on that path. > > Also agreed. I'll rework it. > Actually I wasn't right. That error path should probably stay how it is

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Phil Elwell
On 10/08/2017 11:21, Dan Carpenter wrote: > The original patch did not go through the normal review process... > > On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: >> I'm all for fixing memory leaks, but freeing a block while it is still >> being used is a recipe for hard-to-debug kern

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
The original patch did not go through the normal review process... On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: > I'm all for fixing memory leaks, but freeing a block while it is still > being used is a recipe for hard-to-debug kernel exceptions. > This bug completely breaks the