Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Edward Lipinsky
On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote: > On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > > > Thanks, that makes sense. I tried deleting the if statement and printk() > > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > >

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Edward Lipinsky
On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote: > On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > > > Thanks, that makes sense. I tried deleting the if statement and printk() > > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > >

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Mike Rapoport
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > Thanks, that makes sense. I tried deleting the if statement and printk() > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > calling hw_sm750_map() and checking for errors: > > if (sm750_dev->revid ==

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Mike Rapoport
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > Thanks, that makes sense. I tried deleting the if statement and printk() > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > calling hw_sm750_map() and checking for errors: > > if (sm750_dev->revid ==

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-10 Thread Edward Lipinsky
On Fri, Oct 07, 2016 at 11:12:04AM +0200, Mike Rapoport wrote: > On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > > This patch fixes the

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-10 Thread Edward Lipinsky
On Fri, Oct 07, 2016 at 11:12:04AM +0200, Mike Rapoport wrote: > On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > > This patch fixes the

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-07 Thread Mike Rapoport
On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > This patch fixes the checkpatch.pl warning: > > > > > > WARNING: printk() should include KERN_

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-07 Thread Mike Rapoport
On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > This patch fixes the checkpatch.pl warning: > > > > > > WARNING: printk() should include KERN_

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-06 Thread Edward Lipinsky
On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > This patch fixes the checkpatch.pl warning: > > > > WARNING: printk() should include KERN_ facility level > > > > Signed-off-by: Edward Lipinsky

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-06 Thread Edward Lipinsky
On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > This patch fixes the checkpatch.pl warning: > > > > WARNING: printk() should include KERN_ facility level > > > > Signed-off-by: Edward Lipinsky > > --- > >

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: printk() should include KERN_ facility level > > Signed-off-by: Edward Lipinsky > --- > drivers/staging/sm750fb/ddk750_help.c | 2 +- > 1 file

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: printk() should include KERN_ facility level > > Signed-off-by: Edward Lipinsky > --- > drivers/staging/sm750fb/ddk750_help.c | 2 +- > 1 file changed, 1 insertion(+), 1