Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name? It's bad > form to be printing kernel addresses to the syslog these days given that > it is a security information leak :( Yes probably and it isn't that much of a help when debugging either. I'll resend a v2. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name? It's bad > form to be printing kernel addresses to the syslog these days given that > it is a security information leak :( Yes probably and it isn't that much of a help when debugging either. I'll resend a v2. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name? It's bad > form to be printing kernel addresses to the syslog these days given that > it is a security information leak :( Probably yes. Given it's not etremely helpful when debugging either I'll send a v2 with the address dropped. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name? It's bad > form to be printing kernel addresses to the syslog these days given that > it is a security information leak :( Probably yes. Given it's not etremely helpful when debugging either I'll send a v2 with the address dropped. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > Print the name of an undiscoverable attribute group as well, not just > the pointer's address. Shouldn't we just drop the pointer address and use the name? It's bad form to be printing kernel addresses to the syslog these days given that it is a security information leak :( thanks, greg k-h
Re: [PATCH] sysfs print name of undiscoverable attribute group as well
On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > Print the name of an undiscoverable attribute group as well, not just > the pointer's address. Shouldn't we just drop the pointer address and use the name? It's bad form to be printing kernel addresses to the syslog these days given that it is a security information leak :( thanks, greg k-h
