Re: [PATCH] trace: add missing forward declaration

On Tue, 17 Apr 2018 12:29:09 +0200 Greg Kroah-Hartman wrote: > On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > > It does not fail with any config without this fix. This is for new work. > > Then why not submit it as part of the "new work" patch

Re: [PATCH] trace: add missing forward declaration

On Tue, 17 Apr 2018 12:29:09 +0200 Greg Kroah-Hartman wrote: > On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > > It does not fail with any config without this fix. This is for new work. > > Then why not submit it as part of the "new work" patch series? That's > how

Re: [PATCH] trace: add missing forward declaration

The new work series are not ready yet. I think this patch does make the source better so here is the small patch alone. -- Ahbong On Tue, Apr 17, 2018 at 6:29 PM Greg Kroah-Hartman < gre...@linuxfoundation.org> wrote: > On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > > It does

Re: [PATCH] trace: add missing forward declaration

The new work series are not ready yet. I think this patch does make the source better so here is the small patch alone. -- Ahbong On Tue, Apr 17, 2018 at 6:29 PM Greg Kroah-Hartman < gre...@linuxfoundation.org> wrote: > On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > > It does

Re: [PATCH] trace: add missing forward declaration

On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > It does not fail with any config without this fix. This is for new work. Then why not submit it as part of the "new work" patch series? That's how dependancies are normally handled. thanks, greg k-h

Re: [PATCH] trace: add missing forward declaration

On Tue, Apr 17, 2018 at 02:18:47AM +, Ahbong Chang wrote: > It does not fail with any config without this fix. This is for new work. Then why not submit it as part of the "new work" patch series? That's how dependancies are normally handled. thanks, greg k-h

Re: [PATCH] trace: add missing forward declaration

It does not fail with any config without this fix. This is for new work. -- Ahbong On Mon, Apr 16, 2018 at 9:24 PM Steven Rostedt wrote: > On Mon, 16 Apr 2018 10:36:25 +0800 > Ahbong Chang wrote: > > Without this forward declaration compile may fail

Re: [PATCH] trace: add missing forward declaration

It does not fail with any config without this fix. This is for new work. -- Ahbong On Mon, Apr 16, 2018 at 9:24 PM Steven Rostedt wrote: > On Mon, 16 Apr 2018 10:36:25 +0800 > Ahbong Chang wrote: > > Without this forward declaration compile may fail if this header is > > included only for

Re: [PATCH] trace: add missing forward declaration

On Mon, 16 Apr 2018 10:36:25 +0800 Ahbong Chang wrote: > Without this forward declaration compile may fail if this header is > included only for registering other probe event without struct > pool_workqueue. > Is this for new work or is there a config which this fails with

Re: [PATCH] trace: add missing forward declaration

On Mon, 16 Apr 2018 10:36:25 +0800 Ahbong Chang wrote: > Without this forward declaration compile may fail if this header is > included only for registering other probe event without struct > pool_workqueue. > Is this for new work or is there a config which this fails with today? -- Steve >