Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote: > Greg Kroah-Hartman writes: > > > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: > >> All of the code is #if 0'd out, and the change just replaces a > >> space with a newline, so this obviously doesn't change anything. > > > > How about just deleting all the #if 0 code out entirely so no one has to > > worry about it anymore? > > Fine by me. Like this? > > From: Rasmus Villemoes > Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code > > This is all #if 0'ed out, and it contains some rather weird stuff > (post-increment of a bool, for example). Nuke it. > > Signed-off-by: Rasmus Villemoes Looks good, if you send it in a stand-along email, I can even apply it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
Greg Kroah-Hartman writes:
> On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
>> All of the code is #if 0'd out, and the change just replaces a
>> space with a newline, so this obviously doesn't change anything.
>
> How about just deleting all the #if 0 code out entirely so no one has to
> worry about it anymore?
Fine by me. Like this?
From: Rasmus Villemoes
Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for example). Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
index 7b1d113..25e751b 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
@@ -1706,20 +1706,6 @@ void rtl8821ae_dm_bt_inq_page_monitor(struct
ieee80211_hw *hw)
rtlpcipriv->btcoexist.current_state &=~
BT_COEX_STATE_BT_INQ_PAGE;
}
}
-
-#if 0
- if (hal_coex_8821ae.b_c2h_bt_inquiry_page) {
- hal_coex_8821ae.b_c2h_bt_inquiry_page++;
- // bt inquiry or page is started.
- } if(hal_coex_8821ae.b_c2h_bt_inquiry_page) {
- rtlpcipriv->btcoexist.current_state |=
BT_COEX_STATE_BT_INQ_PAGE;
- if(hal_coex_8821ae.bt_inquiry_page_cnt >= 4)
- hal_coex_8821ae.bt_inquiry_page_cnt = 0;
- hal_coex_8821ae.bt_inquiry_page_cnt++;
- } else {
- rtlpcipriv->btcoexist.current_state &=~
BT_COEX_STATE_BT_INQ_PAGE;
- }
-#endif
}
void rtl8821ae_dm_bt_reset_action_profile_state(struct ieee80211_hw *hw)
--
1.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: > All of the code is #if 0'd out, and the change just replaces a > space with a newline, so this obviously doesn't change anything. How about just deleting all the #if 0 code out entirely so no one has to worry about it anymore? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: All of the code is #if 0'd out, and the change just replaces a space with a newline, so this obviously doesn't change anything. How about just deleting all the #if 0 code out entirely so no one has to worry about it anymore? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
Greg Kroah-Hartman gre...@linuxfoundation.org writes:
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
All of the code is #if 0'd out, and the change just replaces a
space with a newline, so this obviously doesn't change anything.
How about just deleting all the #if 0 code out entirely so no one has to
worry about it anymore?
Fine by me. Like this?
From: Rasmus Villemoes li...@rasmusvillemoes.dk
Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for example). Nuke it.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
index 7b1d113..25e751b 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
@@ -1706,20 +1706,6 @@ void rtl8821ae_dm_bt_inq_page_monitor(struct
ieee80211_hw *hw)
rtlpcipriv-btcoexist.current_state =~
BT_COEX_STATE_BT_INQ_PAGE;
}
}
-
-#if 0
- if (hal_coex_8821ae.b_c2h_bt_inquiry_page) {
- hal_coex_8821ae.b_c2h_bt_inquiry_page++;
- // bt inquiry or page is started.
- } if(hal_coex_8821ae.b_c2h_bt_inquiry_page) {
- rtlpcipriv-btcoexist.current_state |=
BT_COEX_STATE_BT_INQ_PAGE;
- if(hal_coex_8821ae.bt_inquiry_page_cnt = 4)
- hal_coex_8821ae.bt_inquiry_page_cnt = 0;
- hal_coex_8821ae.bt_inquiry_page_cnt++;
- } else {
- rtlpcipriv-btcoexist.current_state =~
BT_COEX_STATE_BT_INQ_PAGE;
- }
-#endif
}
void rtl8821ae_dm_bt_reset_action_profile_state(struct ieee80211_hw *hw)
--
1.9.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if
On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: All of the code is #if 0'd out, and the change just replaces a space with a newline, so this obviously doesn't change anything. How about just deleting all the #if 0 code out entirely so no one has to worry about it anymore? Fine by me. Like this? From: Rasmus Villemoes li...@rasmusvillemoes.dk Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code This is all #if 0'ed out, and it contains some rather weird stuff (post-increment of a bool, for example). Nuke it. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Looks good, if you send it in a stand-along email, I can even apply it :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
