Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread DaeRyong Jeong
On Wed, Apr 25, 2018 at 03:39:48PM +0100, Alan Cox wrote: > On Wed, 25 Apr 2018 22:20:50 +0900 > DaeRyong Jeong wrote: > > > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > > by th->used and updates tb->used. > > But

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread DaeRyong Jeong
On Wed, Apr 25, 2018 at 03:39:48PM +0100, Alan Cox wrote: > On Wed, 25 Apr 2018 22:20:50 +0900 > DaeRyong Jeong wrote: > > > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > > by th->used and updates tb->used. > > But tty_insert_flip_string_fixed_flag() can be executed

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread DaeRyong Jeong
On Wed, Apr 25, 2018 at 03:41:59PM +0200, Greg KH wrote: > On Wed, Apr 25, 2018 at 10:20:50PM +0900, DaeRyong Jeong wrote: > > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > > by th->used and updates tb->used. > > But tty_insert_flip_string_fixed_flag() can be executed

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread DaeRyong Jeong
On Wed, Apr 25, 2018 at 03:41:59PM +0200, Greg KH wrote: > On Wed, Apr 25, 2018 at 10:20:50PM +0900, DaeRyong Jeong wrote: > > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > > by th->used and updates tb->used. > > But tty_insert_flip_string_fixed_flag() can be executed

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread Alan Cox
On Wed, 25 Apr 2018 22:20:50 +0900 DaeRyong Jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But tty_insert_flip_string_fixed_flag() can be executed concurrently and > tb->used can be updated

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread Alan Cox
On Wed, 25 Apr 2018 22:20:50 +0900 DaeRyong Jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But tty_insert_flip_string_fixed_flag() can be executed concurrently and > tb->used can be updated improperly. The tty input

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread Greg KH
On Wed, Apr 25, 2018 at 10:20:50PM +0900, DaeRyong Jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But tty_insert_flip_string_fixed_flag() can be executed concurrently and > tb->used can be updated improperly. > It leads

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag

2018-04-25 Thread Greg KH
On Wed, Apr 25, 2018 at 10:20:50PM +0900, DaeRyong Jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But tty_insert_flip_string_fixed_flag() can be executed concurrently and > tb->used can be updated improperly. > It leads

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag()

2018-04-20 Thread Greg KH
On Fri, Apr 20, 2018 at 04:40:56PM +0900, daelyong jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But it is possible that tty_insert_flip_string_fixed_flag() is executed > concurrently and tb->used is updated

Re: [PATCH] tty: Fix data race in tty_insert_flip_string_fixed_flag()

2018-04-20 Thread Greg KH
On Fri, Apr 20, 2018 at 04:40:56PM +0900, daelyong jeong wrote: > tty_insert_flip_string_fixed_flag() copies chars to the buffer indicated > by th->used and updates tb->used. > But it is possible that tty_insert_flip_string_fixed_flag() is executed > concurrently and tb->used is updated