Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Felipe Balbi
Hi, (you need to break your lines at 80 characters) Corentin LABBE writes: > Le 16/11/2015 18:07, Felipe Balbi a écrit : >> >> Hi, >> >> LABBE Corentin writes: >>> of_match_device could return NULL, and so cause a NULL pointer >>> dereference later. Renaming id to of_id (like all others do)

Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Corentin LABBE
Le 16/11/2015 18:07, Felipe Balbi a écrit : > > Hi, > > LABBE Corentin writes: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later. Renaming id to of_id (like all others do) in the >> process. >> >> Reported-by: coverity (CID 1324133) >> Signed-off-by: LABBE

Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Felipe Balbi
Hi, LABBE Corentin writes: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. Renaming id to of_id (like all others do) in the > process. > > Reported-by: coverity (CID 1324133) > Signed-off-by: LABBE Corentin > --- > drivers/usb/phy/phy-msm-usb.c | 9

Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Felipe Balbi
Hi, LABBE Corentin writes: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. Renaming id to of_id (like all others do) in the > process. > > Reported-by: coverity (CID 1324133) > Signed-off-by: LABBE Corentin

Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Corentin LABBE
Le 16/11/2015 18:07, Felipe Balbi a écrit : > > Hi, > > LABBE Corentin writes: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later. Renaming id to of_id (like all others do) in the >> process. >> >> Reported-by: coverity (CID

Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

2015-11-16 Thread Felipe Balbi
Hi, (you need to break your lines at 80 characters) Corentin LABBE writes: > Le 16/11/2015 18:07, Felipe Balbi a écrit : >> >> Hi, >> >> LABBE Corentin writes: >>> of_match_device could return NULL, and so cause a NULL pointer >>>