Re: [PATCH] vfio: Simplify capability helper

On Wed, Dec 13, 2017 at 04:32:10PM +0100, Auger Eric wrote: > Hi, > > On 13/12/17 16:04, Auger Eric wrote: > > Hi Peter, > > > > On 13/12/17 07:49, Peter Xu wrote: > >> On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > >>> The vfio_info_add_capability() helper requires the

Re: [PATCH] vfio: Simplify capability helper

On Wed, Dec 13, 2017 at 04:32:10PM +0100, Auger Eric wrote: > Hi, > > On 13/12/17 16:04, Auger Eric wrote: > > Hi Peter, > > > > On 13/12/17 07:49, Peter Xu wrote: > >> On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > >>> The vfio_info_add_capability() helper requires the

Re: [PATCH] vfio: Simplify capability helper

On Wed, Dec 13, 2017 at 08:35:39AM -0700, Alex Williamson wrote: > On Wed, 13 Dec 2017 16:04:48 +0100 > Auger Eric wrote: > > > Hi Peter, > > > > On 13/12/17 07:49, Peter Xu wrote: > > > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > > >> The

Re: [PATCH] vfio: Simplify capability helper

On Wed, Dec 13, 2017 at 08:35:39AM -0700, Alex Williamson wrote: > On Wed, 13 Dec 2017 16:04:48 +0100 > Auger Eric wrote: > > > Hi Peter, > > > > On 13/12/17 07:49, Peter Xu wrote: > > > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > > >> The vfio_info_add_capability()

Re: [PATCH] vfio: Simplify capability helper

On Wed, 13 Dec 2017 16:04:48 +0100 Auger Eric wrote: > Hi Peter, > > On 13/12/17 07:49, Peter Xu wrote: > > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > >> The vfio_info_add_capability() helper requires the caller to pass a > >> capability ID,

Re: [PATCH] vfio: Simplify capability helper

On Wed, 13 Dec 2017 16:04:48 +0100 Auger Eric wrote: > Hi Peter, > > On 13/12/17 07:49, Peter Xu wrote: > > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > >> The vfio_info_add_capability() helper requires the caller to pass a > >> capability ID, which it then uses to fill

Re: [PATCH] vfio: Simplify capability helper

Hi, On 13/12/17 16:04, Auger Eric wrote: > Hi Peter, > > On 13/12/17 07:49, Peter Xu wrote: >> On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: >>> The vfio_info_add_capability() helper requires the caller to pass a >>> capability ID, which it then uses to fill in header fields,

Re: [PATCH] vfio: Simplify capability helper

Hi, On 13/12/17 16:04, Auger Eric wrote: > Hi Peter, > > On 13/12/17 07:49, Peter Xu wrote: >> On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: >>> The vfio_info_add_capability() helper requires the caller to pass a >>> capability ID, which it then uses to fill in header fields,

Re: [PATCH] vfio: Simplify capability helper

Hi Peter, On 13/12/17 07:49, Peter Xu wrote: > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: >> The vfio_info_add_capability() helper requires the caller to pass a >> capability ID, which it then uses to fill in header fields, assuming >> hard coded versions. This makes for an

Re: [PATCH] vfio: Simplify capability helper

Hi Peter, On 13/12/17 07:49, Peter Xu wrote: > On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: >> The vfio_info_add_capability() helper requires the caller to pass a >> capability ID, which it then uses to fill in header fields, assuming >> hard coded versions. This makes for an

Re: [PATCH] vfio: Simplify capability helper

Hi Alex, On 12/12/17 20:59, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we want this

Re: [PATCH] vfio: Simplify capability helper

Hi Alex, On 12/12/17 20:59, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we want this

Re: [PATCH] vfio: Simplify capability helper

On 12/13/2017 12:31 PM, Zhenyu Wang wrote: > On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: >> On 13/12/17 06:59, Alex Williamson wrote: >>> The vfio_info_add_capability() helper requires the caller to pass a >>> capability ID, which it then uses to fill in header fields, assuming >>>

Re: [PATCH] vfio: Simplify capability helper

On 12/13/2017 12:31 PM, Zhenyu Wang wrote: > On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: >> On 13/12/17 06:59, Alex Williamson wrote: >>> The vfio_info_add_capability() helper requires the caller to pass a >>> capability ID, which it then uses to fill in header fields, assuming >>>

Re: [PATCH] vfio: Simplify capability helper

On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: > On 13/12/17 06:59, Alex Williamson wrote: > > The vfio_info_add_capability() helper requires the caller to pass a > > capability ID, which it then uses to fill in header fields, assuming > > hard coded versions. This makes for an awkward

Re: [PATCH] vfio: Simplify capability helper

On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: > On 13/12/17 06:59, Alex Williamson wrote: > > The vfio_info_add_capability() helper requires the caller to pass a > > capability ID, which it then uses to fill in header fields, assuming > > hard coded versions. This makes for an awkward

Re: [PATCH] vfio: Simplify capability helper

On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we

Re: [PATCH] vfio: Simplify capability helper

On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we

Re: [PATCH] vfio: Simplify capability helper

On 13/12/17 06:59, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we want this helper to do

Re: [PATCH] vfio: Simplify capability helper

On 13/12/17 06:59, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we want this helper to do