Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-13 Thread Henrique de Moraes Holschuh
On Wed, 12 Feb 2014, dl...@gmx.de wrote: > From: Behan Webster > The only real change is passing in event_mask to the formerly nested > functions. > Otherwise it's just moving around function and macro code. > > This is the only place in the Linux kernel where nested functions are still in >

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-13 Thread Henrique de Moraes Holschuh
On Wed, 12 Feb 2014, dl...@gmx.de wrote: From: Behan Webster beh...@converseincode.com The only real change is passing in event_mask to the formerly nested functions. Otherwise it's just moving around function and macro code. This is the only place in the Linux kernel where nested

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Al Viro
On Wed, Feb 12, 2014 at 01:54:43PM -0800, David Rientjes wrote: > So this patch is only as a courtesy to clang and you're not complaining > about things like __builtin() functions, typeof, or a ? : b conditional > operators because clang happens to support them? That patch removes a disgusting

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread David Rientjes
On Wed, 12 Feb 2014, dl...@gmx.de wrote: > From: Behan Webster > > The only real change is passing in event_mask to the formerly nested > functions. > Otherwise it's just moving around function and macro code. > > This is the only place in the Linux kernel where nested functions are still in

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Måns Rullgård
Behan Webster writes: > On 02/12/14 13:11, Christoph Hellwig wrote: >> On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: >>> being able to compile the Linux kernel with Clang. The use of nested >>> functions >>> blocks this effort. >> Is there any good way to make gcc warn about the

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Richard Weinberger
On Wed, Feb 12, 2014 at 10:20 PM, Behan Webster wrote: > On 02/12/14 13:11, Christoph Hellwig wrote: >> >> On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: >>> >>> being able to compile the Linux kernel with Clang. The use of nested >>> functions >>> blocks this effort. >> >> Is

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Behan Webster
On 02/12/14 13:11, Christoph Hellwig wrote: On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: being able to compile the Linux kernel with Clang. The use of nested functions blocks this effort. Is there any good way to make gcc warn about the use of nested functions? Interesting

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Christoph Hellwig
On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: > being able to compile the Linux kernel with Clang. The use of nested functions > blocks this effort. Is there any good way to make gcc warn about the use of nested functions? -- To unsubscribe from this list: send the line

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Christoph Hellwig
On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: being able to compile the Linux kernel with Clang. The use of nested functions blocks this effort. Is there any good way to make gcc warn about the use of nested functions? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Behan Webster
On 02/12/14 13:11, Christoph Hellwig wrote: On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: being able to compile the Linux kernel with Clang. The use of nested functions blocks this effort. Is there any good way to make gcc warn about the use of nested functions? Interesting

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Richard Weinberger
On Wed, Feb 12, 2014 at 10:20 PM, Behan Webster beh...@converseincode.com wrote: On 02/12/14 13:11, Christoph Hellwig wrote: On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: being able to compile the Linux kernel with Clang. The use of nested functions blocks this effort. Is

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Måns Rullgård
Behan Webster beh...@converseincode.com writes: On 02/12/14 13:11, Christoph Hellwig wrote: On Wed, Feb 12, 2014 at 09:58:46PM +0100, dl...@gmx.de wrote: being able to compile the Linux kernel with Clang. The use of nested functions blocks this effort. Is there any good way to make gcc

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread David Rientjes
On Wed, 12 Feb 2014, dl...@gmx.de wrote: From: Behan Webster beh...@converseincode.com The only real change is passing in event_mask to the formerly nested functions. Otherwise it's just moving around function and macro code. This is the only place in the Linux kernel where nested

Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

2014-02-12 Thread Al Viro
On Wed, Feb 12, 2014 at 01:54:43PM -0800, David Rientjes wrote: So this patch is only as a courtesy to clang and you're not complaining about things like __builtin() functions, typeof, or a ? : b conditional operators because clang happens to support them? That patch removes a disgusting