Re: [PATCH] x86/asm: improve how GEN_*_SUFFIXED_RMWcc() specify clobbers

2018-02-22 Thread Jan Beulich
>>> On 21.02.18 at 22:39, wrote: > On Mon, Feb 19, 2018 at 6:49 AM, Jan Beulich wrote: >> Commit df3405245a ("x86/asm: Add suffix macro for GEN_*_RMWcc()") >> introduced "suffix" RMWcc operations, adding bogus clobber specifiers: >> For one, on x86 there's no point explicitly clobbering "cc". In

Re: [PATCH] x86/asm: improve how GEN_*_SUFFIXED_RMWcc() specify clobbers

2018-02-21 Thread hpa
On February 21, 2018 1:39:18 PM PST, Kees Cook wrote: >On Mon, Feb 19, 2018 at 6:49 AM, Jan Beulich wrote: >> Commit df3405245a ("x86/asm: Add suffix macro for GEN_*_RMWcc()") >> introduced "suffix" RMWcc operations, adding bogus clobber >specifiers: >> For one, on x86 there's no point explicitly

Re: [PATCH] x86/asm: improve how GEN_*_SUFFIXED_RMWcc() specify clobbers

2018-02-21 Thread Kees Cook
On Mon, Feb 19, 2018 at 6:49 AM, Jan Beulich wrote: > Commit df3405245a ("x86/asm: Add suffix macro for GEN_*_RMWcc()") > introduced "suffix" RMWcc operations, adding bogus clobber specifiers: > For one, on x86 there's no point explicitly clobbering "cc". In fact, Do you have more details on this