Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-13 Thread Hans de Goede
Hi Benjamin, On 09-10-2019 17:54, Benjamin Berg wrote: On modern CPUs it is quite normal that the temperature limits are reached and the CPU is throttled. In fact, often the thermal design is not sufficient to cool the CPU at full load and limits can quickly be reached when a burst in load happe

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-11 Thread Benjamin Berg
Hi Srinivas, On Thu, 2019-10-10 at 14:08 -0700, Srinivas Pandruvada wrote: > I have a patch to address this. Instead of avoiding any critical > warnings or wait for 300 seconds for next one, the warning is based on > how long the system is working on throttled condition. If for example > the fan b

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-10 Thread Srinivas Pandruvada
Hi Benjamin, On Wed, 2019-10-09 at 19:56 +0200, Borislav Petkov wrote: > On Wed, Oct 09, 2019 at 05:54:24PM +0200, Benjamin Berg wrote: > > On modern CPUs it is quite normal that the temperature limits are > > reached and the CPU is throttled. In fact, often the thermal design > > is > > not suffi

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Joe Perches
On Wed, 2019-10-09 at 20:22 +0200, Borislav Petkov wrote: > On Wed, Oct 09, 2019 at 11:05:37AM -0700, Joe Perches wrote: > > Perhaps this should be > > > > pr_warn_ratelimited(...) > > > > as the temperature changes can be relatively quick. > > There's already ratelimiting machinery a bit ab

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Borislav Petkov
On Wed, Oct 09, 2019 at 11:05:37AM -0700, Joe Perches wrote: > Perhaps this should be > > pr_warn_ratelimited(...) > > as the temperature changes can be relatively quick. There's already ratelimiting machinery a bit above in the same function. -- Regards/Gruss, Boris. https://people

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Joe Perches
On Wed, 2019-10-09 at 19:56 +0200, Borislav Petkov wrote: > On Wed, Oct 09, 2019 at 05:54:24PM +0200, Benjamin Berg wrote: > > On modern CPUs it is quite normal that the temperature limits are > > reached and the CPU is throttled. In fact, often the thermal design is > > not sufficient to cool the

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Borislav Petkov
On Wed, Oct 09, 2019 at 05:54:24PM +0200, Benjamin Berg wrote: > On modern CPUs it is quite normal that the temperature limits are > reached and the CPU is throttled. In fact, often the thermal design is > not sufficient to cool the CPU at full load and limits can quickly be > reached when a burst

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Hans de Goede
Hi, On 09-10-2019 17:54, Benjamin Berg wrote: On modern CPUs it is quite normal that the temperature limits are reached and the CPU is throttled. In fact, often the thermal design is not sufficient to cool the CPU at full load and limits can quickly be reached when a burst in load happens. This