Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Borislav Petkov
On Thu, Dec 06, 2018 at 05:36:03PM +, Luck, Tony wrote: > > So the real question is, is there a signifcant class of MCE events that > > are not tied to the reporting channel which is per CPU (-ish ...) MCA > > banks? > > Perhaps QPI/UPI interconnect errors? Whatever, this is pure

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Borislav Petkov
On Thu, Dec 06, 2018 at 05:36:03PM +, Luck, Tony wrote: > > So the real question is, is there a signifcant class of MCE events that > > are not tied to the reporting channel which is per CPU (-ish ...) MCA > > banks? > > Perhaps QPI/UPI interconnect errors? Whatever, this is pure

RE: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Luck, Tony
> So the real question is, is there a signifcant class of MCE events that > are not tied to the reporting channel which is per CPU (-ish ...) MCA > banks? Perhaps QPI/UPI interconnect errors? -Tony

RE: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Luck, Tony
> So the real question is, is there a signifcant class of MCE events that > are not tied to the reporting channel which is per CPU (-ish ...) MCA > banks? Perhaps QPI/UPI interconnect errors? -Tony

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > > Oh - I thought we'd have arch/x86/mce/ or so? > > > > There's machine check events that are not tied to any particular CPU, > > correct? So this would be the right conceptual level - and it would also

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-06 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > > Oh - I thought we'd have arch/x86/mce/ or so? > > > > There's machine check events that are not tied to any particular CPU, > > correct? So this would be the right conceptual level - and it would also

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > Oh - I thought we'd have arch/x86/mce/ or so? > > There's machine check events that are not tied to any particular CPU, > correct? So this would be the right conceptual level - and it would also > remove the somewhat redundant

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > Oh - I thought we'd have arch/x86/mce/ or so? > > There's machine check events that are not tied to any particular CPU, > correct? So this would be the right conceptual level - and it would also > remove the somewhat redundant

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > > Would it make sense to organize it a bit more and separate out vendor > > specific functionality: > > > > mce/cpu/intel.c > > mce/cpu/intel-p5.c > > mce/cpu/amd.c > > mce/cpu/winchip.c > >

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > > Would it make sense to organize it a bit more and separate out vendor > > specific functionality: > > > > mce/cpu/intel.c > > mce/cpu/intel-p5.c > > mce/cpu/amd.c > > mce/cpu/winchip.c > >

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > Would it make sense to organize it a bit more and separate out vendor > specific functionality: > > mce/cpu/intel.c > mce/cpu/intel-p5.c > mce/cpu/amd.c > mce/cpu/winchip.c That's too fine-grained IMO and look at the path

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > Would it make sense to organize it a bit more and separate out vendor > specific functionality: > > mce/cpu/intel.c > mce/cpu/intel-p5.c > mce/cpu/amd.c > mce/cpu/winchip.c That's too fine-grained IMO and look at the path

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Luck, Tony
On Wed, Dec 05, 2018 at 03:13:23PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Luck, Tony
On Wed, Dec 05, 2018 at 03:13:23PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming in the MCE subsystem: > > mce/ > |--

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming in the MCE subsystem: > > mce/ > |--