Hi Paolo,
I've tried the below patch and it seems to work fine. This does not
consider
PIO case and as you rightly pointed PIO should trigger #NPF relatively
rarely.
At least so far in my runs I have not seen PIO causing #NPF. If this sounds
acceptable approach then I can submit v2 with these
Hi Paolo,
I've tried the below patch and it seems to work fine. This does not
consider
PIO case and as you rightly pointed PIO should trigger #NPF relatively
rarely.
At least so far in my runs I have not seen PIO causing #NPF. If this sounds
acceptable approach then I can submit v2 with these
On 28/04/2017 21:15, Brijesh Singh wrote:
> Hi Radim,
>
>>
>> This will probably return false negatives when then vcpu->arch.gpa_val
>> couldn't be used anyway (possibly after a VM exits), so it is hard to
>> draw a conclusion.
>>
>> I would really like if we had a solution that passed the gpa
On 28/04/2017 21:15, Brijesh Singh wrote:
> Hi Radim,
>
>>
>> This will probably return false negatives when then vcpu->arch.gpa_val
>> couldn't be used anyway (possibly after a VM exits), so it is hard to
>> draw a conclusion.
>>
>> I would really like if we had a solution that passed the gpa
Hi Radim,
This will probably return false negatives when then vcpu->arch.gpa_val
couldn't be used anyway (possibly after a VM exits), so it is hard to
draw a conclusion.
I would really like if we had a solution that passed the gpa inside
function parameters.
(Btw. cr2 can also be a virtual
Hi Radim,
This will probably return false negatives when then vcpu->arch.gpa_val
couldn't be used anyway (possibly after a VM exits), so it is hard to
draw a conclusion.
I would really like if we had a solution that passed the gpa inside
function parameters.
(Btw. cr2 can also be a virtual
2017-04-25 17:02-0500, Brijesh Singh:
> > > I also wanted to avoid adding yet another variable but we can't depend on
> > > cr2 parameters passed into x86_emulate_instruction().
> > >
> > > The x86_emulate_instruction() function is called from two places:
> > >
> > > 1) handling the page-fault.
2017-04-25 17:02-0500, Brijesh Singh:
> > > I also wanted to avoid adding yet another variable but we can't depend on
> > > cr2 parameters passed into x86_emulate_instruction().
> > >
> > > The x86_emulate_instruction() function is called from two places:
> > >
> > > 1) handling the page-fault.
I also wanted to avoid adding yet another variable but we can't depend on
cr2 parameters passed into x86_emulate_instruction().
The x86_emulate_instruction() function is called from two places:
1) handling the page-fault.
pf_interception [svm.c]
kvm_mmu_page_fault [mmu.c]
I also wanted to avoid adding yet another variable but we can't depend on
cr2 parameters passed into x86_emulate_instruction().
The x86_emulate_instruction() function is called from two places:
1) handling the page-fault.
pf_interception [svm.c]
kvm_mmu_page_fault [mmu.c]
2017-04-24 17:14-0500, Brijesh Singh:
>> >/* GPA available (AMD only) */
>> >bool gpa_available;
>> > + gpa_t gpa_val;
>>
>> Can't we pass this information through function parameters?
>>
>> (I'd rather avoid intractable variables.)
>>
>
> I also wanted to avoid adding yet another
2017-04-24 17:14-0500, Brijesh Singh:
>> >/* GPA available (AMD only) */
>> >bool gpa_available;
>> > + gpa_t gpa_val;
>>
>> Can't we pass this information through function parameters?
>>
>> (I'd rather avoid intractable variables.)
>>
>
> I also wanted to avoid adding yet another
Hi Radim,
/* GPA available (AMD only) */
bool gpa_available;
+ gpa_t gpa_val;
Can't we pass this information through function parameters?
(I'd rather avoid intractable variables.)
I also wanted to avoid adding yet another variable but we can't depend on
cr2
Hi Radim,
/* GPA available (AMD only) */
bool gpa_available;
+ gpa_t gpa_val;
Can't we pass this information through function parameters?
(I'd rather avoid intractable variables.)
I also wanted to avoid adding yet another variable but we can't depend on
cr2
2017-04-24 11:52-0400, Brijesh Singh:
> On AMD hardware when a guest causes a NFP which requires emulation,
> the vcpu->arch.gpa_available flag is set to indicate that cr2 contains
> a valid GPA.
>
> Currently, emulator_read_write_onepage() makes use of gpa_available flag
> to avoid a guest page
2017-04-24 11:52-0400, Brijesh Singh:
> On AMD hardware when a guest causes a NFP which requires emulation,
> the vcpu->arch.gpa_available flag is set to indicate that cr2 contains
> a valid GPA.
>
> Currently, emulator_read_write_onepage() makes use of gpa_available flag
> to avoid a guest page
On 04/24/2017 10:52 AM, Brijesh Singh wrote:
On AMD hardware when a guest causes a NFP which requires emulation,
Just realized a typo in patch description, s/NFP/NPF
the vcpu->arch.gpa_available flag is set to indicate that cr2 contains
a valid GPA.
Currently,
On 04/24/2017 10:52 AM, Brijesh Singh wrote:
On AMD hardware when a guest causes a NFP which requires emulation,
Just realized a typo in patch description, s/NFP/NPF
the vcpu->arch.gpa_available flag is set to indicate that cr2 contains
a valid GPA.
Currently,
18 matches
Mail list logo
