On Fri, 9 Mar 2007 12:04:59 +0800, Sonic Zhang wrote:
> On 3/8/07, Jean Delvare <[EMAIL PROTECTED]> wrote:
> > i2c-core can emulate SMBus transactions using master_xfer, so in
> > general when you have a complete master_xfer implementation you do not
> > need to define a separate smbus_xfer
On Fri, 9 Mar 2007 12:04:59 +0800, Sonic Zhang wrote:
On 3/8/07, Jean Delvare [EMAIL PROTECTED] wrote:
i2c-core can emulate SMBus transactions using master_xfer, so in
general when you have a complete master_xfer implementation you do not
need to define a separate smbus_xfer function. This
On 3/8/07, Jean Delvare <[EMAIL PROTECTED]> wrote:
Hi Brian,
Thanks for the quick update.
> +
> + rc = (iface->result >= 0) ? 0 : -1;
> +
> + /* Release mutex */
> + mutex_unlock(>twi_lock);
> +
> + return rc;
> +}
i2c-core can emulate SMBus transactions using master_xfer,
Hi Brian,
Thanks for the quick update.
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> Reviewed-by: Andrew
On 3/8/07, Jean Delvare [EMAIL PROTECTED] wrote:
Hi Brian,
Thanks for the quick update.
+
+ rc = (iface-result = 0) ? 0 : -1;
+
+ /* Release mutex */
+ mutex_unlock(iface-twi_lock);
+
+ return rc;
+}
i2c-core can emulate SMBus transactions using master_xfer, so in
Hi Brian,
Thanks for the quick update.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
Reviewed-by: Andrew Morton
On Tue, 6 Mar 2007 23:45:29 -0800, Andrew Morton wrote:
> On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
>
> > Thanks a lot, could you please give me a script just to kill this
> > whitespace? So I can do it before sending you patches.
>
>
> Is pretty simple:
>
>
> From: Andrew Morton
> Newsgroups: gmane.linux.kernel
> Subject: Re: [PATCH -mm] Blackfin: blackfin i2c driver
> Date: Tue, 6 Mar 2007 23:45:29 -0800
[]
> On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
>
>> Thanks a lot, could
> > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> > ---
> > drivers/i2c/busses/Kconfig | 47
> > drivers/i2c/busses/i2c-bfin-gpio.c | 98 +
> > drivers/i2c/busses/i2c-bfin-twi.c | 589
> >
>
> I'd prefer
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/i2c/busses/Kconfig | 47
drivers/i2c/busses/i2c-bfin-gpio.c | 98 +
drivers/i2c/busses/i2c-bfin-twi.c | 589
I'd prefer i2c-blackfin-gpio and
From: Andrew Morton
Newsgroups: gmane.linux.kernel
Subject: Re: [PATCH -mm] Blackfin: blackfin i2c driver
Date: Tue, 6 Mar 2007 23:45:29 -0800
[]
On Wed, 07 Mar 2007 15:39:27 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Thanks a lot, could you please give me a script just to kill
On Tue, 6 Mar 2007 23:45:29 -0800, Andrew Morton wrote:
On Wed, 07 Mar 2007 15:39:27 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Thanks a lot, could you please give me a script just to kill this
whitespace? So I can do it before sending you patches.
Is pretty simple:
#!/bin/sh
#
#
On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Thanks a lot, could you please give me a script just to kill this
> whitespace? So I can do it before sending you patches.
Is pretty simple:
#!/bin/sh
#
# Strip any trailing whitespace which a unified diff adds.
#
On Tue, 2007-03-06 at 23:14 -0800, Andrew Morton wrote:
> On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <[EMAIL PROTECTED]> wrote:
>
> > > +config BFIN_SDA
> >
> > I2C_BLACKFIN_SDA
>
> The blackfin architecture uses "bfin" pretty much universally, so this
> usage is consistent.
>
>
On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <[EMAIL PROTECTED]> wrote:
> > +config BFIN_SDA
>
> I2C_BLACKFIN_SDA
The blackfin architecture uses "bfin" pretty much universally, so this
usage is consistent.
box:/usr/src/25> grep -i blackfin patches/blackfin*|wc -l
1608
box:/usr/src/25>
On Wed, 07 Mar 2007 13:57:58 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Here is the updated blackfin i2c driver.
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c
Hi Bryan,
On Wed, 07 Mar 2007 13:57:58 +0800, Wu, Bryan wrote:
> Here is the updated blackfin i2c driver.
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
>
> >
> > OK, I change it into yield(). So, current process will be move to the
> > tail of the run queue. Is that OK with you?
>
> Nope, yield is terribly bad when there are busy processes running: it can
> stall for a very long time indeed,
>
> Is this hardware not capable of generating an
On Wed, 7 Mar 2007 13:17:57 +0800 "Sonic Zhang" <[EMAIL PROTECTED]> wrote:
> On 3/6/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> >
> > > Hi folks,
> > >
> > > [PATCH] Blackfin: blackfin i2c driver
> > >
>
> > > +
Dear Andrew and Alexey:
Thanks a lot for the review.
Here is the updated blackfin i2c driver.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Signed-off-by: Bryan Wu
On 3/6/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Hi folks,
>
> [PATCH] Blackfin: blackfin i2c driver
>
> + struct i2c_msg *pmsg;
> + int i, ret;
> + int rc = 0;
> +
> + if
On 3/6/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> +static int __init i2c_bfin_twi_init(void)
> +{
> + rc = request_irq(twi_iface.irq, bfin_twi_interrupt_entry, SA_INTERRUPT,
"i2c-bfin-twi", _iface);
> + if (rc) {
> + printk(KERN_ERR "i2c-bfin-twi: can't get IRQ %d
On Tue, Mar 06, 2007 at 02:54:18PM +0800, Wu, Bryan wrote:
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
> +config TWICLK_KHZ
> + int "TWI clock (kHZ)"
> +
On Tue, Mar 06, 2007 at 02:54:18PM +0800, Wu, Bryan wrote:
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
+config TWICLK_KHZ
+ int TWI clock (kHZ)
+
On 3/6/07, Alexey Dobriyan [EMAIL PROTECTED] wrote:
+static int __init i2c_bfin_twi_init(void)
+{
+ rc = request_irq(twi_iface.irq, bfin_twi_interrupt_entry, SA_INTERRUPT,
i2c-bfin-twi, twi_iface);
+ if (rc) {
+ printk(KERN_ERR i2c-bfin-twi: can't get IRQ %d !\n,
On 3/6/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Tue, 06 Mar 2007 14:54:18 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Hi folks,
[PATCH] Blackfin: blackfin i2c driver
+ struct i2c_msg *pmsg;
+ int i, ret;
+ int rc = 0;
+
+ if (!(bfin_read_TWI_CONTROL() TWI_ENA))
+
Dear Andrew and Alexey:
Thanks a lot for the review.
Here is the updated blackfin i2c driver.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Signed-off-by: Bryan Wu
On Wed, 7 Mar 2007 13:17:57 +0800 Sonic Zhang [EMAIL PROTECTED] wrote:
On 3/6/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Tue, 06 Mar 2007 14:54:18 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Hi folks,
[PATCH] Blackfin: blackfin i2c driver
+ struct i2c_msg *pmsg;
+
OK, I change it into yield(). So, current process will be move to the
tail of the run queue. Is that OK with you?
Nope, yield is terribly bad when there are busy processes running: it can
stall for a very long time indeed,
Is this hardware not capable of generating an interrupt when
Hi Bryan,
On Wed, 07 Mar 2007 13:57:58 +0800, Wu, Bryan wrote:
Here is the updated blackfin i2c driver.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
On Wed, 07 Mar 2007 13:57:58 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Here is the updated blackfin i2c driver.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare [EMAIL PROTECTED] wrote:
+config BFIN_SDA
I2C_BLACKFIN_SDA
The blackfin architecture uses bfin pretty much universally, so this
usage is consistent.
box:/usr/src/25 grep -i blackfin patches/blackfin*|wc -l
1608
box:/usr/src/25 grep -i bfin
On Tue, 2007-03-06 at 23:14 -0800, Andrew Morton wrote:
On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare [EMAIL PROTECTED] wrote:
+config BFIN_SDA
I2C_BLACKFIN_SDA
The blackfin architecture uses bfin pretty much universally, so this
usage is consistent.
box:/usr/src/25 grep -i
On Wed, 07 Mar 2007 15:39:27 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Thanks a lot, could you please give me a script just to kill this
whitespace? So I can do it before sending you patches.
Is pretty simple:
#!/bin/sh
#
# Strip any trailing whitespace which a unified diff adds.
#
strip1()
On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Hi folks,
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
Little things...
>
On Tue, 06 Mar 2007 14:54:18 +0800 Wu, Bryan [EMAIL PROTECTED] wrote:
Hi folks,
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Little things...
+static int
36 matches
Mail list logo
