Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Wei Yongjun
On 10/30/2016 11:57 AM, Jens Axboe wrote: > On 10/29/2016 10:10 AM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fixes the following sparse warning: >> >> drivers/block/brd.c:411:15: warning: >> symbol 'rd_size' was not declared. Should it be static? > > We just tried

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Wei Yongjun
On 10/30/2016 11:57 AM, Jens Axboe wrote: > On 10/29/2016 10:10 AM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fixes the following sparse warning: >> >> drivers/block/brd.c:411:15: warning: >> symbol 'rd_size' was not declared. Should it be static? > > We just tried this, it's used in arm: >

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Jan Kara
On Sat 29-10-16 16:10:27, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/block/brd.c:411:15: warning: > symbol 'rd_size' was not declared. Should it be static? It should not. It is used in arch/arm/.

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Jan Kara
On Sat 29-10-16 16:10:27, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/block/brd.c:411:15: warning: > symbol 'rd_size' was not declared. Should it be static? It should not. It is used in arch/arm/.

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-29 Thread Jens Axboe
On 10/29/2016 10:10 AM, Wei Yongjun wrote: From: Wei Yongjun Fixes the following sparse warning: drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared. Should it be static? We just tried this, it's used in arm: arch/arm/kernel/atags_parse.c static

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-29 Thread Jens Axboe
On 10/29/2016 10:10 AM, Wei Yongjun wrote: From: Wei Yongjun Fixes the following sparse warning: drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared. Should it be static? We just tried this, it's used in arm: arch/arm/kernel/atags_parse.c static int __init