Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Wei Yongjun 
On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun 
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>>  symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
> extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.

Thank you very much.

Regards,
Yongjun Wei

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Wei Yongjun 
On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun 
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>>  symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
> extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.

Thank you very much.

Regards,
Yongjun Wei

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Jan Kara 
On Sat 29-10-16 16:10:27, Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> Fixes the following sparse warning:
> 
> drivers/block/brd.c:411:15: warning:
>  symbol 'rd_size' was not declared. Should it be static?

It should not. It is used in arch/arm/.

Honza
-- 
Jan Kara 
SUSE Labs, CR

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-30 Thread Jan Kara 
On Sat 29-10-16 16:10:27, Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> Fixes the following sparse warning:
> 
> drivers/block/brd.c:411:15: warning:
>  symbol 'rd_size' was not declared. Should it be static?

It should not. It is used in arch/arm/.

Honza
-- 
Jan Kara 
SUSE Labs, CR

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-29 Thread Jens Axboe 

On 10/29/2016 10:10 AM, Wei Yongjun wrote:

From: Wei Yongjun 

Fixes the following sparse warning:

drivers/block/brd.c:411:15: warning:
 symbol 'rd_size' was not declared. Should it be static?


We just tried this, it's used in arm:

arch/arm/kernel/atags_parse.c

static int __init parse_tag_ramdisk(const struct tag *tag)
{
extern int rd_size, rd_image_start, rd_prompt, rd_doload;
[...]

--
Jens Axboe

Re: [PATCH -next] brd: make symbol rd_size static

2016-10-29 Thread Jens Axboe 

On 10/29/2016 10:10 AM, Wei Yongjun wrote:

From: Wei Yongjun 

Fixes the following sparse warning:

drivers/block/brd.c:411:15: warning:
 symbol 'rd_size' was not declared. Should it be static?


We just tried this, it's used in arm:

arch/arm/kernel/atags_parse.c

static int __init parse_tag_ramdisk(const struct tag *tag)
{
extern int rd_size, rd_image_start, rd_prompt, rd_doload;
[...]

--
Jens Axboe