Re: [PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

2017-09-21 Thread Randy Dunlap
On 09/21/17 09:49, Mark Brown wrote:
> On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:
> 
>> +++ linux-next-20170921/drivers/spi/Kconfig
>> @@ -625,6 +625,7 @@ config SPI_SIRF
>>  config SPI_SPRD_ADI
>>  tristate "Spreadtrum ADI controller"
>>  depends on ARCH_SPRD || COMPILE_TEST
>> +depends on HWSPINLOCK
>>  help
>>ADI driver based on SPI for Spreadtrum SoCs.
> 
> Why is this a more sensible fix than providing stubs for HWSPINLOCK?
> 

There are already stubs there. I'll send an updated patch.

-- 
~Randy


Re: [PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

2017-09-21 Thread Randy Dunlap
On 09/21/17 09:49, Mark Brown wrote:
> On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:
> 
>> +++ linux-next-20170921/drivers/spi/Kconfig
>> @@ -625,6 +625,7 @@ config SPI_SIRF
>>  config SPI_SPRD_ADI
>>  tristate "Spreadtrum ADI controller"
>>  depends on ARCH_SPRD || COMPILE_TEST
>> +depends on HWSPINLOCK
>>  help
>>ADI driver based on SPI for Spreadtrum SoCs.
> 
> Why is this a more sensible fix than providing stubs for HWSPINLOCK?
> 

There are already stubs there. I'll send an updated patch.

-- 
~Randy


Re: [PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

2017-09-21 Thread Mark Brown
On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:

> +++ linux-next-20170921/drivers/spi/Kconfig
> @@ -625,6 +625,7 @@ config SPI_SIRF
>  config SPI_SPRD_ADI
>   tristate "Spreadtrum ADI controller"
>   depends on ARCH_SPRD || COMPILE_TEST
> + depends on HWSPINLOCK
>   help
> ADI driver based on SPI for Spreadtrum SoCs.

Why is this a more sensible fix than providing stubs for HWSPINLOCK?


signature.asc
Description: PGP signature


Re: [PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

2017-09-21 Thread Mark Brown
On Thu, Sep 21, 2017 at 09:10:04AM -0700, Randy Dunlap wrote:

> +++ linux-next-20170921/drivers/spi/Kconfig
> @@ -625,6 +625,7 @@ config SPI_SIRF
>  config SPI_SPRD_ADI
>   tristate "Spreadtrum ADI controller"
>   depends on ARCH_SPRD || COMPILE_TEST
> + depends on HWSPINLOCK
>   help
> ADI driver based on SPI for Spreadtrum SoCs.

Why is this a more sensible fix than providing stubs for HWSPINLOCK?


signature.asc
Description: PGP signature