Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Fri, Mar 6, 2015 at 1:49 PM, Bjorn Helgaas wrote: > On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: >> On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson >> wrote: >> > I'd kinda like to use pci_ignore_hotplug() for devices in use by a >> > user via vfio-pci, but the interface seems only partially implemented >> > since we can only set ignore_hotplug and not clear it. This adds the >> > capability to clear the flag and applies it as seems to be appropriate >> > to the existing users. I don't have a system with power control for >> > a radeon or nouveau device, so I'd certainly appreciate testing. It >> > seems though that once the device is in D0, we've passed the critical >> > point where the device could be accidentally unplugged. Thanks, >> >> Something re-broke this recently. See: >> https://bugzilla.kernel.org/show_bug.cgi?id=61891 >> https://bugzilla.kernel.org/show_bug.cgi?id=89731 > > I'm not opposed to adding pci_unignore_hotplug() when we have users for it. > I don't really want to throw in the nouveau and radeon changes while there > are open issues in the same area, though. > > I haven't looked at the bugzillas above. Let me know if I should. Please do. My comments were not targeted at this patch set, but rather at the fact that pci hotplug (acpiphp in this case) is again trying to remove the driver even though it's flagged to ignore hotplug in the hybrid laptop case. Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: > On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson > wrote: > > I'd kinda like to use pci_ignore_hotplug() for devices in use by a > > user via vfio-pci, but the interface seems only partially implemented > > since we can only set ignore_hotplug and not clear it. This adds the > > capability to clear the flag and applies it as seems to be appropriate > > to the existing users. I don't have a system with power control for > > a radeon or nouveau device, so I'd certainly appreciate testing. It > > seems though that once the device is in D0, we've passed the critical > > point where the device could be accidentally unplugged. Thanks, > > Something re-broke this recently. See: > https://bugzilla.kernel.org/show_bug.cgi?id=61891 > https://bugzilla.kernel.org/show_bug.cgi?id=89731 I'm not opposed to adding pci_unignore_hotplug() when we have users for it. I don't really want to throw in the nouveau and radeon changes while there are open issues in the same area, though. I haven't looked at the bugzillas above. Let me know if I should. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user via vfio-pci, but the interface seems only partially implemented since we can only set ignore_hotplug and not clear it. This adds the capability to clear the flag and applies it as seems to be appropriate to the existing users. I don't have a system with power control for a radeon or nouveau device, so I'd certainly appreciate testing. It seems though that once the device is in D0, we've passed the critical point where the device could be accidentally unplugged. Thanks, Something re-broke this recently. See: https://bugzilla.kernel.org/show_bug.cgi?id=61891 https://bugzilla.kernel.org/show_bug.cgi?id=89731 I'm not opposed to adding pci_unignore_hotplug() when we have users for it. I don't really want to throw in the nouveau and radeon changes while there are open issues in the same area, though. I haven't looked at the bugzillas above. Let me know if I should. Bjorn -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Fri, Mar 6, 2015 at 1:49 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user via vfio-pci, but the interface seems only partially implemented since we can only set ignore_hotplug and not clear it. This adds the capability to clear the flag and applies it as seems to be appropriate to the existing users. I don't have a system with power control for a radeon or nouveau device, so I'd certainly appreciate testing. It seems though that once the device is in D0, we've passed the critical point where the device could be accidentally unplugged. Thanks, Something re-broke this recently. See: https://bugzilla.kernel.org/show_bug.cgi?id=61891 https://bugzilla.kernel.org/show_bug.cgi?id=89731 I'm not opposed to adding pci_unignore_hotplug() when we have users for it. I don't really want to throw in the nouveau and radeon changes while there are open issues in the same area, though. I haven't looked at the bugzillas above. Let me know if I should. Please do. My comments were not targeted at this patch set, but rather at the fact that pci hotplug (acpiphp in this case) is again trying to remove the driver even though it's flagged to ignore hotplug in the hybrid laptop case. Alex -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson wrote: > I'd kinda like to use pci_ignore_hotplug() for devices in use by a > user via vfio-pci, but the interface seems only partially implemented > since we can only set ignore_hotplug and not clear it. This adds the > capability to clear the flag and applies it as seems to be appropriate > to the existing users. I don't have a system with power control for > a radeon or nouveau device, so I'd certainly appreciate testing. It > seems though that once the device is in D0, we've passed the critical > point where the device could be accidentally unplugged. Thanks, Something re-broke this recently. See: https://bugzilla.kernel.org/show_bug.cgi?id=61891 https://bugzilla.kernel.org/show_bug.cgi?id=89731 Alex > > Alex > > --- > > Alex Williamson (2): > pci: Add reciprocal function for pci_ignore_hotplug() > nouveau/radeon: Un-ignore hotplug on resume > > > drivers/gpu/drm/nouveau/nouveau_drm.c |1 + > drivers/gpu/drm/radeon/radeon_drv.c |1 + > include/linux/pci.h |5 + > 3 files changed, 7 insertions(+) > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user via vfio-pci, but the interface seems only partially implemented since we can only set ignore_hotplug and not clear it. This adds the capability to clear the flag and applies it as seems to be appropriate to the existing users. I don't have a system with power control for a radeon or nouveau device, so I'd certainly appreciate testing. It seems though that once the device is in D0, we've passed the critical point where the device could be accidentally unplugged. Thanks, Something re-broke this recently. See: https://bugzilla.kernel.org/show_bug.cgi?id=61891 https://bugzilla.kernel.org/show_bug.cgi?id=89731 Alex Alex --- Alex Williamson (2): pci: Add reciprocal function for pci_ignore_hotplug() nouveau/radeon: Un-ignore hotplug on resume drivers/gpu/drm/nouveau/nouveau_drm.c |1 + drivers/gpu/drm/radeon/radeon_drv.c |1 + include/linux/pci.h |5 + 3 files changed, 7 insertions(+) ___ dri-devel mailing list dri-de...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
