Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
Em Mon, Oct 29, 2012 at 12:13:28PM +0100, Jiri Olsa escreveu: > On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: > > On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: > > > separating dso related stuff into dso object plus some other symbol > > > object cleanup. It's just a code moving, no actual change was done. > > Looks good to me. > > Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this > > series. > humm, so you could compile it wth no problem..? what system are you? ;) util/dso.c:1:20: error: symbol.h: No such file or directory [acme@sandy linux]$ head -4 tools/perf/util/dso.c #include #include "dso.h" #include "util.h" #include "debug.h" [acme@sandy linux]$ If I use "symbol.h" it builds, I've fixed this one here, thanks. The problem is that I use O=, building it without it works. - ARnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
On Mon, 29 Oct 2012 12:13:28 +0100, Jiri Olsa wrote: > On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: >> Hi Jiri, >> >> On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: >> > hi, >> > separating dso related stuff into dso object plus some other symbol >> > object cleanup. It's just a code moving, no actual change was done. >> > >> > Attached patches: >> > 1/5 perf tool: Move build_id__sprintf into build-id object >> > 2/5 perf tool: Move BUILD_ID_SIZE into build-id object >> > 3/5 perf tool: Move hex2u64 into util object >> > 4/5 perf tool: Move strxfrchar into string object >> > 5/5 perf tool: Move dso_* related functions into dso object >> >> Looks good to me. >> >> Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this >> series. > > humm, so you could compile it wth no problem..? what system are you? ;) I just compiled your branch. :) I'll check it again if you send out the v2. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: > > hi, > > separating dso related stuff into dso object plus some other symbol > > object cleanup. It's just a code moving, no actual change was done. > > > > Attached patches: > > 1/5 perf tool: Move build_id__sprintf into build-id object > > 2/5 perf tool: Move BUILD_ID_SIZE into build-id object > > 3/5 perf tool: Move hex2u64 into util object > > 4/5 perf tool: Move strxfrchar into string object > > 5/5 perf tool: Move dso_* related functions into dso object > > Looks good to me. > > Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this > series. humm, so you could compile it wth no problem..? what system are you? ;) thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
Hi Jiri, On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: > hi, > separating dso related stuff into dso object plus some other symbol > object cleanup. It's just a code moving, no actual change was done. > > Attached patches: > 1/5 perf tool: Move build_id__sprintf into build-id object > 2/5 perf tool: Move BUILD_ID_SIZE into build-id object > 3/5 perf tool: Move hex2u64 into util object > 4/5 perf tool: Move strxfrchar into string object > 5/5 perf tool: Move dso_* related functions into dso object Looks good to me. Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this series. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
Hi Jiri, On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: hi, separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Attached patches: 1/5 perf tool: Move build_id__sprintf into build-id object 2/5 perf tool: Move BUILD_ID_SIZE into build-id object 3/5 perf tool: Move hex2u64 into util object 4/5 perf tool: Move strxfrchar into string object 5/5 perf tool: Move dso_* related functions into dso object Looks good to me. Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this series. Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: Hi Jiri, On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: hi, separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Attached patches: 1/5 perf tool: Move build_id__sprintf into build-id object 2/5 perf tool: Move BUILD_ID_SIZE into build-id object 3/5 perf tool: Move hex2u64 into util object 4/5 perf tool: Move strxfrchar into string object 5/5 perf tool: Move dso_* related functions into dso object Looks good to me. Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this series. humm, so you could compile it wth no problem..? what system are you? ;) thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
On Mon, 29 Oct 2012 12:13:28 +0100, Jiri Olsa wrote: On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: Hi Jiri, On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: hi, separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Attached patches: 1/5 perf tool: Move build_id__sprintf into build-id object 2/5 perf tool: Move BUILD_ID_SIZE into build-id object 3/5 perf tool: Move hex2u64 into util object 4/5 perf tool: Move strxfrchar into string object 5/5 perf tool: Move dso_* related functions into dso object Looks good to me. Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this series. humm, so you could compile it wth no problem..? what system are you? ;) I just compiled your branch. :) I'll check it again if you send out the v2. Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
Em Mon, Oct 29, 2012 at 12:13:28PM +0100, Jiri Olsa escreveu: On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Looks good to me. Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this series. humm, so you could compile it wth no problem..? what system are you? ;) util/dso.c:1:20: error: symbol.h: No such file or directory [acme@sandy linux]$ head -4 tools/perf/util/dso.c #include symbol.h #include dso.h #include util.h #include debug.h [acme@sandy linux]$ If I use symbol.h it builds, I've fixed this one here, thanks. The problem is that I use O=, building it without it works. - ARnaldo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
