Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 05:21:00PM +, Lorenzo Pieralisi wrote: > If you have a simple reproducer for the bugs I am happy to help you test > it (I can also apply arm64 DYNAMIC_FTRACE_WITH_REGS patches and test that > new code path if that's the final direction we are taking). The easiest way

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 05:21:00PM +, Lorenzo Pieralisi wrote: > If you have a simple reproducer for the bugs I am happy to help you test > it (I can also apply arm64 DYNAMIC_FTRACE_WITH_REGS patches and test that > new code path if that's the final direction we are taking). The easiest way

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 09:47:52AM -0700, Keith Busch wrote: > On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > > The question is whether we really need to dynamically patch the kernel > > with ftrace to achieve what that patch does. > > > > Furthermore, it would also be good

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 09:47:52AM -0700, Keith Busch wrote: > On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > > The question is whether we really need to dynamically patch the kernel > > with ftrace to achieve what that patch does. > > > > Furthermore, it would also be good

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > The question is whether we really need to dynamically patch the kernel > with ftrace to achieve what that patch does. > > Furthermore, it would also be good to report what bugs we are actually > fixing, from what you are writing

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > The question is whether we really need to dynamically patch the kernel > with ftrace to achieve what that patch does. > > Furthermore, it would also be good to report what bugs we are actually > fixing, from what you are writing

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-09 Thread Will Deacon
Hi Bjorn, On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > [+cc arm64 folks, LKML: This conversation is about this patch: > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > which fixes some PCIe AER error injection bugs, but also makes

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-09 Thread Will Deacon
Hi Bjorn, On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > [+cc arm64 folks, LKML: This conversation is about this patch: > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > which fixes some PCIe AER error injection bugs, but also makes

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-08 Thread Bjorn Helgaas
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-08 Thread Bjorn Helgaas
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-08 Thread Keith Busch
On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > [+cc arm64 folks, LKML: This conversation is about this patch: > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > which fixes some PCIe AER error injection bugs, but also makes the error >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-08 Thread Keith Busch
On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > [+cc arm64 folks, LKML: This conversation is about this patch: > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > which fixes some PCIe AER error injection bugs, but also makes the error >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-05 Thread Bjorn Helgaas
[+cc arm64 folks, LKML: This conversation is about this patch: https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com which fixes some PCIe AER error injection bugs, but also makes the error injector dependent on DYNAMIC_FTRACE_WITH_REGS, which not all arches support.

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-10-05 Thread Bjorn Helgaas
[+cc arm64 folks, LKML: This conversation is about this patch: https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com which fixes some PCIe AER error injection bugs, but also makes the error injector dependent on DYNAMIC_FTRACE_WITH_REGS, which not all arches support.