Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-10 Thread Joel Fernandes
On Wed, Jun 10, 2020 at 04:21:42PM -0700, Paul E. McKenney wrote: [...] > > > 8.To softirq 3. Either GP or CB kthread for the transitioning > > > CPU advances to next. > > > At this point, the no-CBs setup is fully shut down. > > > 9.To softirq 4. Transitioning code advances

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-10 Thread Paul E. McKenney
On Thu, Jun 11, 2020 at 12:12:46AM +0200, Frederic Weisbecker wrote: > On Wed, Jun 10, 2020 at 07:02:10AM -0700, Paul E. McKenney wrote: > > And just to argue against myself... > > > > Another approach is to maintain explicit multiple states for each > > ->cblist, perhaps something like this: > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-10 Thread Frederic Weisbecker
On Wed, Jun 10, 2020 at 07:02:10AM -0700, Paul E. McKenney wrote: > And just to argue against myself... > > Another approach is to maintain explicit multiple states for each > ->cblist, perhaps something like this: > > 1.In softirq. Transition code advances to next. > 2.To no-CB 1.

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-10 Thread Paul E. McKenney
On Wed, Jun 10, 2020 at 03:12:39PM +0200, Frederic Weisbecker wrote: > On Tue, Jun 09, 2020 at 11:02:27AM -0700, Paul E. McKenney wrote: > > > > > And anyway we still want to unconditionally lock on many places, > > > > > regardless of the offloaded state. I don't know how we could have > > > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-10 Thread Frederic Weisbecker
On Tue, Jun 09, 2020 at 11:02:27AM -0700, Paul E. McKenney wrote: > > > > And anyway we still want to unconditionally lock on many places, > > > > regardless of the offloaded state. I don't know how we could have > > > > a magic helper do the unconditional lock on some places and the > > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-09 Thread Paul E. McKenney
On Mon, Jun 08, 2020 at 02:57:17PM +0200, Frederic Weisbecker wrote: > On Thu, Jun 04, 2020 at 09:36:55AM -0700, Paul E. McKenney wrote: > > On Thu, Jun 04, 2020 at 01:41:22PM +0200, Frederic Weisbecker wrote: > > > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > > > On Wed,

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-08 Thread Frederic Weisbecker
On Thu, Jun 04, 2020 at 09:36:55AM -0700, Paul E. McKenney wrote: > On Thu, Jun 04, 2020 at 01:41:22PM +0200, Frederic Weisbecker wrote: > > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > > > Reviewed-by:

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-04 Thread Paul E. McKenney
On Thu, Jun 04, 2020 at 01:41:22PM +0200, Frederic Weisbecker wrote: > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > > Reviewed-by: Joel Fernandes (Google) > > > > Thank you for looking this over, Joel! >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-04 Thread Frederic Weisbecker
On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > Reviewed-by: Joel Fernandes (Google) > > Thank you for looking this over, Joel! > > Is it feasible to make rcu_nocb_lock*() and rcu_nocb_unlock*() "do the >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Paul E. McKenney
On Tue, May 26, 2020 at 08:45:42PM -0400, Joel Fernandes wrote: > Hi Paul, > > On Tue, May 26, 2020 at 6:29 PM Paul E. McKenney wrote: > > > > On Tue, May 26, 2020 at 05:27:56PM -0400, Joel Fernandes wrote: > > > On Tue, May 26, 2020 at 02:09:47PM -0700, Paul E. McKenney wrote: > > > [...] > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Joel Fernandes
Hi Paul, On Tue, May 26, 2020 at 6:29 PM Paul E. McKenney wrote: > > On Tue, May 26, 2020 at 05:27:56PM -0400, Joel Fernandes wrote: > > On Tue, May 26, 2020 at 02:09:47PM -0700, Paul E. McKenney wrote: > > [...] > > > > > > BTW, I'm really itching to give it a try to make the scheduler more >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Paul E. McKenney
On Tue, May 26, 2020 at 05:27:56PM -0400, Joel Fernandes wrote: > On Tue, May 26, 2020 at 02:09:47PM -0700, Paul E. McKenney wrote: > [...] > > > > > BTW, I'm really itching to give it a try to make the scheduler more > > > > > deadlock > > > > > resilient (that is, if the scheduler wake up path

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Joel Fernandes
On Tue, May 26, 2020 at 02:09:47PM -0700, Paul E. McKenney wrote: [...] > > > > BTW, I'm really itching to give it a try to make the scheduler more > > > > deadlock > > > > resilient (that is, if the scheduler wake up path detects a deadlock, > > > > then it > > > > defers the wake up using

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Paul E. McKenney
On Tue, May 26, 2020 at 04:18:40PM -0400, Joel Fernandes wrote: > On Tue, May 26, 2020 at 09:29:46AM -0700, Paul E. McKenney wrote: > > On Tue, May 26, 2020 at 11:21:37AM -0400, Joel Fernandes wrote: > > > Hi Paul, > > > > > > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Joel Fernandes
On Tue, May 26, 2020 at 09:29:46AM -0700, Paul E. McKenney wrote: > On Tue, May 26, 2020 at 11:21:37AM -0400, Joel Fernandes wrote: > > Hi Paul, > > > > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Paul E. McKenney
On Tue, May 26, 2020 at 11:21:37AM -0400, Joel Fernandes wrote: > Hi Paul, > > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > > On Wed, May 13, 2020 at 06:47:05PM +0200, Frederic Weisbecker wrote: > > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-26 Thread Joel Fernandes
Hi Paul, On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > On Wed, May 13, 2020 at 06:47:05PM +0200, Frederic Weisbecker wrote: > > > Pure NOCB code entrypoints (nocb_cb kthread, nocb_gp kthread, nocb > > >

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-22 Thread Paul E. McKenney
On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > On Wed, May 13, 2020 at 06:47:05PM +0200, Frederic Weisbecker wrote: > > Pure NOCB code entrypoints (nocb_cb kthread, nocb_gp kthread, nocb > > timers) can unconditionally lock rdp->nocb_lock as they always execute > > in the

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-05-20 Thread Joel Fernandes
On Wed, May 13, 2020 at 06:47:05PM +0200, Frederic Weisbecker wrote: > Pure NOCB code entrypoints (nocb_cb kthread, nocb_gp kthread, nocb > timers) can unconditionally lock rdp->nocb_lock as they always execute > in the context of an offloaded rdp. > > This also prepare for toggling CPUs to/from