Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On 03/11/2014 04:36 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote: On 03/11/2014 04:17 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. MAX_NICE is defined in include/linux/sched/prio.h. It is applied in tip tree, and not in mainline yet. Ok. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). Yes, agree. Another question is that I am not sure when I need to use a macro and when I should use a inline function. Could you help to give me some sugguestion? You can ask three people and get five opinions ;) Hehe :) However if your above define would have been an inline function it wouldn't suffer from possible subtle side effects and it would have sane type checking etc. So usually functions should be preferred. I prefer to inline function too, it makes me feel more safe. I will update this patch with an inline function. Thanx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote: > On 03/11/2014 04:17 PM, Heiko Carstens wrote: > >On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: > >>+#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) > >Where is MAX_NICE defined? The s390 patch fails to compile. > > MAX_NICE is defined in include/linux/sched/prio.h. It is applied in > tip tree, and not in mainline yet. Ok. > >Also you probably want at least extra braces around the 'nice' usage to > >avoid subtle side effects. (or make NICE_TO.. a function, whatever). > > Yes, agree. Another question is that I am not sure when I need to > use a macro and when I should use a inline function. > > Could you help to give me some sugguestion? You can ask three people and get five opinions ;) However if your above define would have been an inline function it wouldn't suffer from possible subtle side effects and it would have sane type checking etc. So usually functions should be preferred. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On 03/11/2014 04:17 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: This patch add a macro named NICE_TO_RLIMIT in prio.h to convert nice value [19,-20] to rlimit style value [1,40]. Signed-off-by: Dongsheng Yang --- include/linux/sched/prio.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/sched/prio.h b/include/linux/sched/prio.h index ac32258..8e78c47 100644 --- a/include/linux/sched/prio.h +++ b/include/linux/sched/prio.h @@ -41,4 +41,9 @@ #define TASK_USER_PRIO(p) USER_PRIO((p)->static_prio) #define MAX_USER_PRIO (USER_PRIO(MAX_PRIO)) +/* + * Convert nice value [19,-20] to rlimit style value [1,40]. + */ +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. MAX_NICE is defined in include/linux/sched/prio.h. It is applied in tip tree, and not in mainline yet. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). Yes, agree. Another question is that I am not sure when I need to use a macro and when I should use a inline function. Could you help to give me some sugguestion? Thanx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: > This patch add a macro named NICE_TO_RLIMIT in prio.h to > convert nice value [19,-20] to rlimit style value [1,40]. > > Signed-off-by: Dongsheng Yang > --- > include/linux/sched/prio.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/sched/prio.h b/include/linux/sched/prio.h > index ac32258..8e78c47 100644 > --- a/include/linux/sched/prio.h > +++ b/include/linux/sched/prio.h > @@ -41,4 +41,9 @@ > #define TASK_USER_PRIO(p)USER_PRIO((p)->static_prio) > #define MAX_USER_PRIO(USER_PRIO(MAX_PRIO)) > > +/* > + * Convert nice value [19,-20] to rlimit style value [1,40]. > + */ > +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: This patch add a macro named NICE_TO_RLIMIT in prio.h to convert nice value [19,-20] to rlimit style value [1,40]. Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com --- include/linux/sched/prio.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/sched/prio.h b/include/linux/sched/prio.h index ac32258..8e78c47 100644 --- a/include/linux/sched/prio.h +++ b/include/linux/sched/prio.h @@ -41,4 +41,9 @@ #define TASK_USER_PRIO(p)USER_PRIO((p)-static_prio) #define MAX_USER_PRIO(USER_PRIO(MAX_PRIO)) +/* + * Convert nice value [19,-20] to rlimit style value [1,40]. + */ +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On 03/11/2014 04:17 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: This patch add a macro named NICE_TO_RLIMIT in prio.h to convert nice value [19,-20] to rlimit style value [1,40]. Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com --- include/linux/sched/prio.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/sched/prio.h b/include/linux/sched/prio.h index ac32258..8e78c47 100644 --- a/include/linux/sched/prio.h +++ b/include/linux/sched/prio.h @@ -41,4 +41,9 @@ #define TASK_USER_PRIO(p) USER_PRIO((p)-static_prio) #define MAX_USER_PRIO (USER_PRIO(MAX_PRIO)) +/* + * Convert nice value [19,-20] to rlimit style value [1,40]. + */ +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. MAX_NICE is defined in include/linux/sched/prio.h. It is applied in tip tree, and not in mainline yet. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). Yes, agree. Another question is that I am not sure when I need to use a macro and when I should use a inline function. Could you help to give me some sugguestion? Thanx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote: On 03/11/2014 04:17 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. MAX_NICE is defined in include/linux/sched/prio.h. It is applied in tip tree, and not in mainline yet. Ok. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). Yes, agree. Another question is that I am not sure when I need to use a macro and when I should use a inline function. Could you help to give me some sugguestion? You can ask three people and get five opinions ;) However if your above define would have been an inline function it wouldn't suffer from possible subtle side effects and it would have sane type checking etc. So usually functions should be preferred. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h.
On 03/11/2014 04:36 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote: On 03/11/2014 04:17 PM, Heiko Carstens wrote: On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. MAX_NICE is defined in include/linux/sched/prio.h. It is applied in tip tree, and not in mainline yet. Ok. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). Yes, agree. Another question is that I am not sure when I need to use a macro and when I should use a inline function. Could you help to give me some sugguestion? You can ask three people and get five opinions ;) Hehe :) However if your above define would have been an inline function it wouldn't suffer from possible subtle side effects and it would have sane type checking etc. So usually functions should be preferred. I prefer to inline function too, it makes me feel more safe. I will update this patch with an inline function. Thanx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
