Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, 2018-05-21 at 13:27 +0200, Linus Walleij wrote: > On Mon, May 14, 2018 at 1:03 PM, Andy Shevchenko > wrote: > > On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: > > > The hunk hitting the x86 BCM43xx driver is especially tricky as > > > the > > > number > > > comes out of SFI which

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, 2018-05-21 at 13:27 +0200, Linus Walleij wrote: > On Mon, May 14, 2018 at 1:03 PM, Andy Shevchenko > wrote: > > On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: > > > The hunk hitting the x86 BCM43xx driver is especially tricky as > > > the > > > number > > > comes out of SFI which

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Tue, Jun 12, 2018 at 10:15:40AM +0200, Linus Walleij wrote: > On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown wrote: > > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > >> Sadly this only handled the undocumented fixed > >> regulator binding "reg-fixed-voltage". So I need to fix

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Tue, Jun 12, 2018 at 10:15:40AM +0200, Linus Walleij wrote: > On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown wrote: > > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > >> Sadly this only handled the undocumented fixed > >> regulator binding "reg-fixed-voltage". So I need to fix

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown wrote: > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > >> The DT binding for "regulator-fixed" specifies that enable-active-high >> should be set for polarity inversion. For historical reasons, I guess, >> we screwed up. The example

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown wrote: > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > >> The DT binding for "regulator-fixed" specifies that enable-active-high >> should be set for polarity inversion. For historical reasons, I guess, >> we screwed up. The example

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > The DT binding for "regulator-fixed" specifies that enable-active-high > should be set for polarity inversion. For historical reasons, I guess, > we screwed up. The example in the binding uses that. No, it just says that if the

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote: > The DT binding for "regulator-fixed" specifies that enable-active-high > should be set for polarity inversion. For historical reasons, I guess, > we screwed up. The example in the binding uses that. No, it just says that if the

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 1, 2018 at 11:35 AM, Thierry Reding wrote: > On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: >> As we augmented the regulator core to accept a GPIO descriptor instead >> of a GPIO number, we can augment the fixed GPIO regulator to look up >> and pass that descriptor

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 1, 2018 at 11:35 AM, Thierry Reding wrote: > On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: >> As we augmented the regulator core to accept a GPIO descriptor instead >> of a GPIO number, we can augment the fixed GPIO regulator to look up >> and pass that descriptor

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 01, 2018 at 11:35:11AM +0200, Thierry Reding wrote: > > cfg.ena_gpio_invert = !config->enable_high; > Change this line to: > cfg.ena_gpio_invert = false; > fixes the regression and is pretty much the implementation of my above > suggestion to ignore enable-active-high,

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 01, 2018 at 11:35:11AM +0200, Thierry Reding wrote: > > cfg.ena_gpio_invert = !config->enable_high; > Change this line to: > cfg.ena_gpio_invert = false; > fixes the regression and is pretty much the implementation of my above > suggestion to ignore enable-active-high,

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 01, 2018 at 11:35:11AM +0200, Thierry Reding wrote: > On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: > > As we augmented the regulator core to accept a GPIO descriptor instead > > of a GPIO number, we can augment the fixed GPIO regulator to look up > > and pass that

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Jun 01, 2018 at 11:35:11AM +0200, Thierry Reding wrote: > On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: > > As we augmented the regulator core to accept a GPIO descriptor instead > > of a GPIO number, we can augment the fixed GPIO regulator to look up > > and pass that

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 10:06:22AM +0200, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 10:06 AM, Linus Walleij wrote: > @@ -892,6 +902,7 @@ static void __init e680_init(void) > > pxa_set_keypad_info(_keypad_platform_data); > > + gpiod_add_lookup_table(_supply_gpiod_table); > pwm_add_table(ezx_pwm_lookup, ARRAY_SIZE(ezx_pwm_lookup)); >

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 10:06 AM, Linus Walleij wrote: > @@ -892,6 +902,7 @@ static void __init e680_init(void) > > pxa_set_keypad_info(_keypad_platform_data); > > + gpiod_add_lookup_table(_supply_gpiod_table); > pwm_add_table(ezx_pwm_lookup, ARRAY_SIZE(ezx_pwm_lookup)); >

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 1:03 PM, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: >> The hunk hitting the x86 BCM43xx driver is especially tricky as the >> number >> comes out of SFI which is a mystery to me. I definately need

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 1:03 PM, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: >> The hunk hitting the x86 BCM43xx driver is especially tricky as the >> number >> comes out of SFI which is a mystery to me. I definately need someone >> to >> look at this. (Hi

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

* Linus Walleij [180514 08:08]: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables.

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

* Linus Walleij [180514 08:08]: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. ... >

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

Hi Linus, On Mon, May 14, 2018 at 10:06 AM, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

Hi Linus, On Mon, May 14, 2018 at 10:06 AM, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. >

Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, 2018-05-14 at 10:06 +0200, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. >