Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-03-03 Thread Rusty Russell
Paolo Bonzini writes: > Il 27/02/2013 12:21, Rusty Russell ha scritto: >> Baseline (before add_sgs): >> 2.84-3.04(2.927292)user >> >> After add_sgs: >> 2.97-3.15(3.053750)user >> >> After simplifying add_buf a little: >>

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-03-03 Thread Rusty Russell
Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 12:21, Rusty Russell ha scritto: Baseline (before add_sgs): 2.84-3.04(2.927292)user After add_sgs: 2.97-3.15(3.053750)user After simplifying add_buf a little:

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-28 Thread Paolo Bonzini
Il 27/02/2013 12:21, Rusty Russell ha scritto: >>> >> Baseline (before add_sgs): >>> >> 2.84-3.04(2.927292)user >>> >> >>> >> After add_sgs: >>> >> 2.97-3.15(3.053750)user >>> >> >>> >> After simplifying add_buf a little: >>> >>

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-28 Thread Paolo Bonzini
Il 27/02/2013 12:21, Rusty Russell ha scritto: Baseline (before add_sgs): 2.84-3.04(2.927292)user After add_sgs: 2.97-3.15(3.053750)user After simplifying add_buf a little: 2.95-3.21(3.081458)user After inlining

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Feb 27, 2013 at 05:58:37PM +1030, Rusty Russell wrote: >> Paolo Bonzini writes: >> > Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: >> >> On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >> >>> virtio_scsi can really use this, to avoid

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-27 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Wed, Feb 27, 2013 at 05:58:37PM +1030, Rusty Russell wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Michael S. Tsirkin
On Wed, Feb 27, 2013 at 05:58:37PM +1030, Rusty Russell wrote: > Paolo Bonzini writes: > > Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: > >> On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: > >>> virtio_scsi can really use this, to avoid the current hack of copying > >>> the

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Rusty Russell
Paolo Bonzini writes: > Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: >> On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >>> virtio_scsi can really use this, to avoid the current hack of copying >>> the whole sg array. Some other things get slightly neater, too. >>> >>>

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Michael S. Tsirkin
On Tue, Feb 26, 2013 at 03:44:26PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: > >> virtio_scsi can really use this, to avoid the current hack of copying > >> the whole sg array. Some other things get slightly

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Michael S. Tsirkin
On Tue, Feb 26, 2013 at 03:44:26PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Rusty Russell
Paolo Bonzini pbonz...@redhat.com writes: Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too.

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Michael S. Tsirkin
On Wed, Feb 27, 2013 at 05:58:37PM +1030, Rusty Russell wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-25 Thread Paolo Bonzini
Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: > On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >> virtio_scsi can really use this, to avoid the current hack of copying >> the whole sg array. Some other things get slightly neater, too. >> >> Signed-off-by: Rusty Russell > >

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-25 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >> virtio_scsi can really use this, to avoid the current hack of copying >> the whole sg array. Some other things get slightly neater, too. >> >> Signed-off-by: Rusty Russell > > Hmm, this makes

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-25 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell ru...@rustcorp.com.au

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-25 Thread Paolo Bonzini
Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-24 Thread Michael S. Tsirkin
On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell Hmm, this makes add_buf a bit slower. virtio_test results

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-24 Thread Michael S. Tsirkin
On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Hmm, this makes add_buf a bit slower.

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell This simpler API makes more sense to me. Reviewed-by: Asias He > --- >

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell ru...@rustcorp.com.au This simpler API makes more sense to me. Reviewed-by: Asias

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-19 Thread Wanlong Gao
On 02/19/2013 03:56 PM, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell I like this simple implementation. Reviewed-by: Wanlong Gao > --- >

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-19 Thread Wanlong Gao
On 02/19/2013 03:56 PM, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell ru...@rustcorp.com.au I like this simple implementation. Reviewed-by: Wanlong Gao