Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif
On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: > On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: > > Unmatched spaces/tabs Makefile indentation could make the > > Makefile fails. While the tabed line could be considered > > sometimes as follow up for rule command, the mixed space > > tab meses up with makefile if conditions. > > I have too many times been beaten that asssignments was > ignored because I used tabs to indendt the assignmnet. > So in all Makefile I edit spaces are used for indent. > Tabs are only used for commands. sounds like good idea, I'll make separate patch for that thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif
On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: > Unmatched spaces/tabs Makefile indentation could make the > Makefile fails. While the tabed line could be considered > sometimes as follow up for rule command, the mixed space > tab meses up with makefile if conditions. I have too many times been beaten that asssignments was ignored because I used tabs to indendt the assignmnet. So in all Makefile I edit spaces are used for indent. Tabs are only used for commands. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif
On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. I have too many times been beaten that asssignments was ignored because I used tabs to indendt the assignmnet. So in all Makefile I edit spaces are used for indent. Tabs are only used for commands. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif
On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. I have too many times been beaten that asssignments was ignored because I used tabs to indendt the assignmnet. So in all Makefile I edit spaces are used for indent. Tabs are only used for commands. sounds like good idea, I'll make separate patch for that thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
