Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-04-12 Thread Paolo Bonzini
On 21/02/2018 18:47, KarimAllah Ahmed wrote: > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > memory that has a "struct page". > > The life-cycle of the mapping also changes to avoid doing map and unmap on > every single exit (which becomes very expesive once we use

Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-04-12 Thread Paolo Bonzini
On 21/02/2018 18:47, KarimAllah Ahmed wrote: > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > memory that has a "struct page". > > The life-cycle of the mapping also changes to avoid doing map and unmap on > every single exit (which becomes very expesive once we use

Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-02-23 Thread Raslan, KarimAllah
On Fri, 2018-02-23 at 16:36 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 21, 2018 at 06:47:16PM +0100, KarimAllah Ahmed wrote: > > > > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > > memory that has a "struct page". > > > > The life-cycle of the mapping also

Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-02-23 Thread Raslan, KarimAllah
On Fri, 2018-02-23 at 16:36 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 21, 2018 at 06:47:16PM +0100, KarimAllah Ahmed wrote: > > > > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > > memory that has a "struct page". > > > > The life-cycle of the mapping also

Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-02-23 Thread Konrad Rzeszutek Wilk
On Wed, Feb 21, 2018 at 06:47:16PM +0100, KarimAllah Ahmed wrote: > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > memory that has a "struct page". > > The life-cycle of the mapping also changes to avoid doing map and unmap on s/also changes/has been changed/ ?

Re: [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap

2018-02-23 Thread Konrad Rzeszutek Wilk
On Wed, Feb 21, 2018 at 06:47:16PM +0100, KarimAllah Ahmed wrote: > ... since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest > memory that has a "struct page". > > The life-cycle of the mapping also changes to avoid doing map and unmap on s/also changes/has been changed/ ?