Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-08-10 Thread Jens Axboe
On 8/10/20 4:56 PM, Dave Chinner wrote: > On Wed, Jun 24, 2020 at 10:44:21AM -0600, Jens Axboe wrote: >> On 6/24/20 10:41 AM, Matthew Wilcox wrote: >>> On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: On 6/24/20 9:00 AM, Jens Axboe wrote: > On 6/23/20 7:46 PM, Matthew Wilcox

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-08-10 Thread Dave Chinner
On Wed, Jun 24, 2020 at 10:44:21AM -0600, Jens Axboe wrote: > On 6/24/20 10:41 AM, Matthew Wilcox wrote: > > On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: > >> On 6/24/20 9:00 AM, Jens Axboe wrote: > >>> On 6/23/20 7:46 PM, Matthew Wilcox wrote: > I'd be quite happy to add a

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-07-07 Thread Jens Axboe
On 7/7/20 5:38 AM, Andreas Grünbacher wrote: > Am Mi., 24. Juni 2020 um 18:48 Uhr schrieb Jens Axboe : >> >> On 6/24/20 10:41 AM, Matthew Wilcox wrote: >>> On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: On 6/24/20 9:00 AM, Jens Axboe wrote: > On 6/23/20 7:46 PM, Matthew

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-07-07 Thread Andreas Grünbacher
Am Mi., 24. Juni 2020 um 18:48 Uhr schrieb Jens Axboe : > > On 6/24/20 10:41 AM, Matthew Wilcox wrote: > > On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: > >> On 6/24/20 9:00 AM, Jens Axboe wrote: > >>> On 6/23/20 7:46 PM, Matthew Wilcox wrote: > I'd be quite happy to add a gfp_t

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/24/20 10:41 AM, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: >> On 6/24/20 9:00 AM, Jens Axboe wrote: >>> On 6/23/20 7:46 PM, Matthew Wilcox wrote: I'd be quite happy to add a gfp_t to struct readahead_control. The other thing I've been looking

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: > On 6/24/20 9:00 AM, Jens Axboe wrote: > > On 6/23/20 7:46 PM, Matthew Wilcox wrote: > >> I'd be quite happy to add a gfp_t to struct readahead_control. > >> The other thing I've been looking into for other reasons is adding > >> a

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/24/20 9:00 AM, Jens Axboe wrote: > On 6/23/20 7:46 PM, Matthew Wilcox wrote: >> On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: >>> On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: The read-ahead shouldn't block, so allow it to be done even if IOCB_NOWAIT is

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/23/20 10:38 PM, Dave Chinner wrote: > On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: >> The read-ahead shouldn't block, so allow it to be done even if >> IOCB_NOWAIT is set in the kiocb. >> >> Acked-by: Johannes Weiner >> Signed-off-by: Jens Axboe > > BTW, Jens, in case nobody

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/23/20 7:46 PM, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: >> On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: >>> The read-ahead shouldn't block, so allow it to be done even if >>> IOCB_NOWAIT is set in the kiocb. >> >> Doesn't think break

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-23 Thread Dave Chinner
On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: > The read-ahead shouldn't block, so allow it to be done even if > IOCB_NOWAIT is set in the kiocb. > > Acked-by: Johannes Weiner > Signed-off-by: Jens Axboe BTW, Jens, in case nobody had mentioned it, the Reply-To field for the

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-23 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: > On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: > > The read-ahead shouldn't block, so allow it to be done even if > > IOCB_NOWAIT is set in the kiocb. > > Doesn't think break preadv2(RWF_NOWAIT) semantics for on buffered

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-23 Thread Dave Chinner
On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: > The read-ahead shouldn't block, so allow it to be done even if > IOCB_NOWAIT is set in the kiocb. > > Acked-by: Johannes Weiner > Signed-off-by: Jens Axboe > --- > mm/filemap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff