Re: [PATCH 05/19] phy: qcom-qmp-ufs: Add support for QCS8300

[Jingyi Wang]

On 9/4/2024 5:36 PM, Krzysztof Kozlowski wrote:
> On 04/09/2024 10:33, Jingyi Wang wrote:
>> From: Xin Liu 
>>
>> Add QMP PHY support for QCS8300 which is compatible with SA8775P.
>>
>> Signed-off-by: Xin Liu 
>> Signed-off-by: Jingyi Wang 
>> ---
>>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c 
>> b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> index d964bdfe8700..8bad68400736 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> @@ -2010,6 +2010,9 @@ static const struct of_device_id 
>> qmp_ufs_of_match_table[] = {
>>  }, {
>>  .compatible = "qcom,msm8998-qmp-ufs-phy",
>>  .data = &sdm845_ufsphy_cfg,
>> +}, {
>> +.compatible = "qcom,qcs8300-qmp-ufs-phy",
>> +.data = &sa8775p_ufsphy_cfg,
> 
> Is compatible? Then this is redundant. Drop.
> 
> Best regards,
> Krzysztof
> 
Will drop that.

Thanks,
Jingyi

Re: [PATCH 05/19] phy: qcom-qmp-ufs: Add support for QCS8300

[Krzysztof Kozlowski]

On 04/09/2024 10:33, Jingyi Wang wrote:
> From: Xin Liu 
> 
> Add QMP PHY support for QCS8300 which is compatible with SA8775P.
> 
> Signed-off-by: Xin Liu 
> Signed-off-by: Jingyi Wang 
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c 
> b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> index d964bdfe8700..8bad68400736 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> @@ -2010,6 +2010,9 @@ static const struct of_device_id 
> qmp_ufs_of_match_table[] = {
>   }, {
>   .compatible = "qcom,msm8998-qmp-ufs-phy",
>   .data = &sdm845_ufsphy_cfg,
> + }, {
> + .compatible = "qcom,qcs8300-qmp-ufs-phy",
> + .data = &sa8775p_ufsphy_cfg,

Is compatible? Then this is redundant. Drop.

Best regards,
Krzysztof